Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrations for ceph and migrating to the new charmcraft.yaml #309

Merged
merged 5 commits into from
Mar 24, 2024

Conversation

simskij
Copy link
Member

@simskij simskij commented Mar 15, 2024

This PR additionally merges our yaml files into charmcraft.yaml.

Issue

Ceph, among other solutions, require embedding of panels and anonymous access.

Solution

Allow anonymous access and embedding of dashboard panels. Configured through juju config, which defaults to disabled.

Context

Testing Instructions

  • Enable the configs and try to access Grafana.
  • Make a dashboard embeddable and try embedding it somewhere.

Upgrade Notes

N/A

@lucabello lucabello changed the title Feature/ceph integration integrations for ceph and migrating to the new charmcraft.yaml Mar 15, 2024
Copy link
Contributor

@Abuelodelanada Abuelodelanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Shouldn't we have an integration test that checks you can access a dashboard with anonymous access?

@simskij
Copy link
Member Author

simskij commented Mar 22, 2024

LGTM.

Shouldn't we have an integration test that checks you can access a dashboard with anonymous access?

To me, that feels a little bit like testing the workload, to be honest.

@simskij simskij merged commit a708cb7 into main Mar 24, 2024
13 checks passed
@simskij simskij deleted the feature/ceph-integration branch March 24, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants