Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dashboard utils (part 3) #374

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Refactor dashboard utils (part 3) #374

merged 7 commits into from
Jan 16, 2025

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Jan 16, 2025

Following up on #370 and #373, as part of simplifying #363.
This PR introduces no functional changes, except:

  • Dashboards read by GrafanaDashboardAggregator (cos-proxy) will now include an "dashboard_alt_uid" key in the metadata, the same as was already done by GrafanaDashboardProvider.
  • More details on a logger.warning logline.

@sed-i sed-i marked this pull request as ready for review January 16, 2025 13:16
@sed-i sed-i requested a review from a team as a code owner January 16, 2025 13:16
@lucabello lucabello merged commit db76a8b into main Jan 16, 2025
13 checks passed
@lucabello lucabello deleted the feature/load_from_dir branch January 16, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants