IAM-1137 - refactor: fetch basename from base tag #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwshimi
commented
Oct 10, 2024
BarcoMasile
approved these changes
Oct 10, 2024
shipperizer
force-pushed
the
fetch-base-from-tag
branch
from
362b1fb
to
68f165e
Compare
shipperizer
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch the basename for the router from the
<base>tag. React Router doesn't support the base tag by default so we have to manually get the path.https://warthogs.atlassian.net/browse/IAM-1137
Fixes: #431.