Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout v4 and get tags #1055

Merged
merged 1 commit into from
Oct 12, 2023
Merged

checkout v4 and get tags #1055

merged 1 commit into from
Oct 12, 2023

Conversation

mina1460
Copy link
Contributor

@mina1460 mina1460 commented Oct 12, 2023

Description

Multiple issues reported issues with fetching tags and latest versions in older actions/checkout version.
see actions/checkout#579 and actions/checkout#448

Hopefully by migrating to the new checkout v4 and forcing fetch-depth to 0 and asking for fetch-tags can solve the issue. In some cases, I add a separate command to git fetch --tags explicitly which should come at no cost given that tags should already be fetched in the previous steps.

Fixes CSS-5482

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

we test it and see if it works or not, if not, we add git fetch --tags as a separate step and that should work

Signed-off-by: mina1460 <mina146@aucegypt.edu>
@mina1460
Copy link
Contributor Author

same changes but to main instead of feature-rebac

@mina1460 mina1460 merged commit 1be2fcc into canonical:main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants