CSS-9588 Enforce stricter model name uniqueness

[kian99]

Description

This PR resolves an issue where a user could create a model with the same name on multiple controllers and because the model owner was the same across these models, Juju clients would behave poorly. The CLI for example would never let you switch between these two models with the same name and owner.

This behaviour is better as it matches Juju's behaviour.

Fixes CSS-9588

Engineering checklist

• Documentation updated
• Covered by unit tests
• Covered by integration tests

[ale8k]

lgtm but can we surface a nice error for this in the addmodel call? Like check for this db err and return a nicer string to the user?

[kian99]

@ale8k

lgtm but can we surface a nice error for this in the addmodel call? Like check for this db err and return a nicer string to the user?

The error returned is shown in the test added to jujuapi -

model bob@canonical.com/my-model already exists (already exists)

Did you want something different from that?

[ale8k]

@ale8k

lgtm but can we surface a nice error for this in the addmodel call? Like check for this db err and return a nicer string to the user?

The error returned is shown in the test added to jujuapi -

model bob@canonical.com/my-model already exists (already exists)

Did you want something different from that?

Yeah something like uhhhhm, I'm bad at this but try word this better:

model X already exists on controller N

I think telling the user what controller it's on is actually kinda useful? Or maybe it isn't... Idk in my head it felt nice

[kian99]

I think telling the user what controller it's on is actually kinda useful? Or maybe it isn't... Idk in my head it felt nice

It's a nice idea, but I think it's preferable to not expose that information since JIMM wants to act as a single controller.