feat: add identity manager #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
force-pushed
the
identity-manager
branch
from
d71909e to
70870c8
Compare
kian99
force-pushed
the
identity-manager
branch
from
70870c8 to
bc09810
Compare
alesstimec
reviewed
Jan 6, 2025
| ) | ||
|
|
||
| // identityManager provides a means to manage identities within JIMM. | ||
| type identityManager struct { |
There was a problem hiding this comment.
i would suggest exporting the identityManager type
There was a problem hiding this comment.
As discussed, I think we should definitely do this but in a separate piece of work.
There was a problem hiding this comment.
please create a jira ticket to at least discuss the issue if not to address it
There was a problem hiding this comment.
| var users []openfga.User | ||
|
|
||
| for _, id := range identities { | ||
| users = append(users, *openfga.NewUser(&id, j.authSvc)) |
There was a problem hiding this comment.
openfga.NewUser looks like another opportunity for a factory.. something like
userFactory := openfga.NewUserFactor(j.authSvc)
and then we could do something like
user := userFactory.New(id)
There was a problem hiding this comment.
Very true, good for a separate piece of work.
alesstimec
approved these changes
Jan 7, 2025
| ) | ||
|
|
||
| // identityManager provides a means to manage identities within JIMM. | ||
| type identityManager struct { |
There was a problem hiding this comment.
please create a jira ticket to at least discuss the issue if not to address it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an identity manager. Note that the identity manager doesn't create identity (that is only done on login), rather the identity manager performs operations like Fetch, Count and List identities.
Fixes JUJU-7254
Engineering checklist