Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synchronization primitive for server shutdown #114

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Jul 2, 2024

This PR adds a way for the Server to wait for other services (like the Backend, the event polling, the cleanup for ttl, the watchers, etc...) to end during shutdown.

It is useful mainly during tests/benchmarks so that we are sure that once the test is over, no service is still running.

@marco6 marco6 marked this pull request as ready for review July 2, 2024 15:02
@marco6 marco6 requested a review from a team as a code owner July 2, 2024 15:02
@marco6 marco6 requested a review from bschimke95 July 2, 2024 15:02
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco6 marco6 merged commit 98bb83a into canonical:master Jul 3, 2024
8 of 9 checks passed
@marco6 marco6 deleted the sync-server-stop branch July 3, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants