Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build flag #117

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Remove build flag #117

merged 2 commits into from
Jul 9, 2024

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Jul 4, 2024

This PR aims at simplifying the run of tests and make sure each test runs only once during the CI pipeline. For this reason, it removes the capability of building this project without dqlite.

The reason for this change is that it is useful to run test with a single command and generate a single report (for coverage, for benchmarks, etc...).

It is still possible (while not very useful) to run only dqlite/sqlite tests by filtering with the -run flag like:

go test -v ./... -run dqlite

@marco6
Copy link
Collaborator Author

marco6 commented Jul 4, 2024

Depends on #116

@marco6
Copy link
Collaborator Author

marco6 commented Jul 8, 2024

Marking as ready since #116 was merged.

@marco6 marco6 marked this pull request as ready for review July 8, 2024 14:25
@marco6 marco6 requested a review from a team as a code owner July 8, 2024 14:25
@marco6 marco6 mentioned this pull request Jul 8, 2024
@marco6 marco6 requested a review from bschimke95 July 9, 2024 07:02
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco6 marco6 merged commit 69db51f into canonical:master Jul 9, 2024
6 of 7 checks passed
@marco6 marco6 deleted the remove-build-flag branch July 9, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants