Instrument Otel #125
Merged
Instrument Otel #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Jul 10, 2024
|
Nice work |
|
Fly-by comment: I've like to see some docs about where the parent span comes from, env? header field? etc. Additionally, given the distributed nature of dqlite, how spans in dlite peers may be linked to each other. |
@dimaqq Great question! In summary, a About your second question, we can created nested spans that are all associated with the same root span. If we need to inject additional information via the HTTP headers we can make use of propagators. |
Benchmark ResultCurrent status |
bschimke95
reviewed
Jul 15, 2024
marco6
requested changes
Jul 15, 2024
pkg/kine/server/create.go
Outdated
| if err == ErrKeyExists { | ||
| span.RecordError(err) |
There was a problem hiding this comment.
This shouldn't be recorded as it is not a misbehavior.
There was a problem hiding this comment.
This part is removed.
pkg/kine/server/create.go
Outdated
| return &etcdserverpb.TxnResponse{ | ||
| Header: txnHeader(rev), | ||
| Succeeded: false, | ||
| }, nil | ||
| } else if err != nil { | ||
| span.RecordError(err) |
There was a problem hiding this comment.
Can we use defer for this?
There was a problem hiding this comment.
So span.RecordError(err) does not stop the span, it will also record just nil if there is no error. Why would you like to use defer here?
marco6
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces otel tracing logs.
Traces
We collect traces on (get/count/create/update/delete/list/update/compact/dbsize), this includes various child traces where relevant.
When you run
/hack/jaeger.shand runk8s-dqlitewith--otel=true, the traces are collected in a local jaeger instance athttp://localhost:16686.Metrics
The metric counters (get/count/create/update/delete/list/update) are written to stdout every 30 seconds.
(Limitation: Jaeger can't accept these metrics)
@bschimke95
Existing metrics
Side-note: Our kine layer already tracks some metrics here:
http://127.0.0.1:9042/metrics:See an example output here