Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable minor schema version updates #141

Merged
merged 8 commits into from
Jul 26, 2024
Merged

Enable minor schema version updates #141

merged 8 commits into from
Jul 26, 2024

Conversation

louiseschmidtgen
Copy link
Contributor

Description

Enable minor schema version updates.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

Benchmark Result

goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                    │    Before     │                After                 │
                    │    sec/op     │    sec/op     vs base                │
Compaction/sqlite-4   3.773m ± 8%     4.042m ± 99%  +7.11% (p=0.007 n=7)
Compaction/dqlite-4   5.086m ± 3%     5.346m ± 10%  +5.12% (p=0.002 n=7)
Create/sqlite-4       1.454m ± 3%     1.519m ±  7%  +4.50% (p=0.017 n=7)
Create/dqlite-4       1.458m ±  ∞ ¹   1.449m ±  3%       ~ (p=0.876 n=5+7)
Delete/sqlite-4       1.573m ± 9%     1.568m ±  6%       ~ (p=0.902 n=7)
Delete/dqlite-4       1.433m ± 5%     1.500m ±  3%       ~ (p=0.051 n=6+7)
Get/sqlite-4          386.1µ ± 2%     385.4µ ±  1%       ~ (p=1.000 n=7)
Get/dqlite-4          505.0µ ± 1%     504.9µ ±  1%       ~ (p=0.535 n=7)
Lease/sqlite-4        106.1µ ± 3%     107.9µ ±  4%       ~ (p=0.259 n=7)
Lease/dqlite-4        108.7µ ± 3%     109.9µ ±  3%       ~ (p=0.318 n=7)
List/sqlite-4         7.527m ± 4%     7.453m ±  3%       ~ (p=0.805 n=7)
List/dqlite-4         43.56m ± 0%     43.59m ±  0%       ~ (p=0.383 n=7)
Update/sqlite-4       1.526m ± 6%     1.503m ± 10%       ~ (p=1.000 n=7)
Update/dqlite-4       1.438m ± 3%     1.510m ±  6%  +5.06% (p=0.017 n=7)
geomean               1.429m          1.455m        +1.81%
¹ need >= 6 samples for confidence interval at level 0.95

                    │        Before        │                     After                      │
                    │ page-cache-misses/op │ page-cache-misses/op  vs base                  │
Compaction/sqlite-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Compaction/dqlite-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Create/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Create/dqlite-4               0.000 ±  ∞ ²             0.000 ± 0%       ~ (p=1.000 n=5+7) ¹
Delete/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Delete/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=6+7) ¹
Get/sqlite-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Get/dqlite-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Lease/sqlite-4                0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Lease/dqlite-4                0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
List/sqlite-4                 0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
List/dqlite-4                 0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Update/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Update/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
geomean                                  ³                         +0.00%                 ³
¹ all samples are equal
² need >= 6 samples for confidence interval at level 0.95
³ summaries must be >0 to compute geomean

                    │        Before        │                     After                      │
                    │ page-cache-spills/op │ page-cache-spills/op  vs base                  │
Compaction/sqlite-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Compaction/dqlite-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Create/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Create/dqlite-4               0.000 ±  ∞ ²             0.000 ± 0%       ~ (p=1.000 n=5+7) ¹
Delete/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Delete/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=6+7) ¹
Get/sqlite-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Get/dqlite-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Lease/sqlite-4                0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Lease/dqlite-4                0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
List/sqlite-4                 0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
List/dqlite-4                 0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Update/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
Update/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7)   ¹
geomean                                  ³                         +0.00%                 ³
¹ all samples are equal
² need >= 6 samples for confidence interval at level 0.95
³ summaries must be >0 to compute geomean

                    │     Before     │                  After                  │
                    │ page-reads/op  │ page-reads/op  vs base                  │
Compaction/sqlite-4    109.8 ±  1%       110.6 ±  3%       ~ (p=0.163 n=7)
Compaction/dqlite-4    118.5 ±  3%       119.3 ±  1%       ~ (p=0.097 n=7)
Create/sqlite-4        21.29 ±  2%       21.22 ±  2%       ~ (p=0.710 n=7)
Create/dqlite-4        18.21 ±   ∞ ¹     18.19 ±  3%       ~ (p=0.639 n=5+7)
Delete/sqlite-4        25.20 ±  2%       25.16 ±  2%       ~ (p=0.684 n=7)
Delete/dqlite-4        21.23 ±  3%       21.12 ±  2%       ~ (p=0.534 n=6+7)
Get/sqlite-4           11.99 ±  0%       11.99 ±  0%       ~ (p=1.000 n=7)
Get/dqlite-4           11.99 ±  0%       11.99 ±  0%       ~ (p=1.000 n=7)
Lease/sqlite-4        1.200m ± 83%      1.200m ± 47%       ~ (p=0.290 n=7)
Lease/dqlite-4        800.0µ ± 50%      800.0µ ± 25%       ~ (p=0.143 n=7)
List/sqlite-4          268.0 ±  5%       265.0 ±  3%       ~ (p=0.672 n=7)
List/dqlite-4          34.03 ±  0%       34.03 ±  0%       ~ (p=1.000 n=7)   ²
Update/sqlite-4        25.02 ±  3%       24.90 ±  3%       ~ (p=0.306 n=7)
Update/dqlite-4        20.18 ±  3%       21.37 ±  2%  +5.90% (p=0.001 n=7)
geomean                7.480             7.503        +0.31%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                    │     Before     │                  After                   │
                    │ page-writes/op │ page-writes/op  vs base                  │
Compaction/sqlite-4     11.25 ± 0%         11.25 ± 0%       ~ (p=0.184 n=7)
Compaction/dqlite-4     8.271 ± 0%         8.282 ± 1%       ~ (p=0.685 n=7)
Create/sqlite-4         5.118 ± 1%         5.113 ± 1%       ~ (p=0.302 n=7)
Create/dqlite-4         4.148 ±  ∞ ¹       4.147 ± 1%       ~ (p=0.722 n=5+7)
Delete/sqlite-4         5.295 ± 0%         5.294 ± 1%       ~ (p=0.876 n=7)
Delete/dqlite-4         4.329 ± 0%         4.314 ± 1%       ~ (p=0.297 n=6+7)
Get/sqlite-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7)   ²
Get/dqlite-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7)   ²
Lease/sqlite-4          0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7)   ²
Lease/dqlite-4          0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7)   ²
List/sqlite-4           0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7)   ²
List/dqlite-4           0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7)   ²
Update/sqlite-4         5.138 ± 0%         5.141 ± 1%       ~ (p=0.435 n=7)
Update/dqlite-4         4.159 ± 0%         4.156 ± 0%       ~ (p=0.153 n=7)
geomean                            ³                   -0.03%                 ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │     Before      │                  After                   │
                    │ sec-reading/op  │ sec-reading/op  vs base                  │
Compaction/sqlite-4   667.8µ ±  31%      799.3µ ± 494%       ~ (p=0.097 n=7)
Compaction/dqlite-4   233.6µ ±  11%      211.6µ ±  18%       ~ (p=0.209 n=7)
Create/sqlite-4       98.70µ ±  20%     105.40µ ± 111%       ~ (p=0.456 n=7)
Create/dqlite-4       43.10µ ±    ∞ ¹    36.50µ ±  66%       ~ (p=0.318 n=5+7)
Delete/sqlite-4       151.5µ ± 119%      163.2µ ± 191%       ~ (p=0.555 n=7)
Delete/dqlite-4       51.50µ ±  24%      52.50µ ±  42%       ~ (p=0.445 n=6+7)
Get/sqlite-4          87.40µ ±   6%      88.60µ ±   6%       ~ (p=0.875 n=7)
Get/dqlite-4          37.00µ ±  24%      35.30µ ±  16%       ~ (p=0.805 n=7)
Lease/sqlite-4         0.000 ±   0%       0.000 ±    ?       ~ (p=1.000 n=7)
Lease/dqlite-4         0.000 ±    ?       0.000 ±   0%       ~ (p=1.000 n=7)
List/sqlite-4         6.816m ±   5%      6.777m ±   4%       ~ (p=0.710 n=7)
List/dqlite-4         350.0µ ±  26%      260.0µ ±  58%       ~ (p=0.138 n=7)
Update/sqlite-4       177.0µ ±  11%      179.4µ ±  45%       ~ (p=0.902 n=7)
Update/dqlite-4       96.40µ ±  11%      93.40µ ±  13%       ~ (p=0.336 n=7)
geomean                             ²                   -1.98%                 ²
¹ need >= 6 samples for confidence interval at level 0.95
² summaries must be >0 to compute geomean

                    │     Before     │                  After                   │
                    │ sec-writing/op │ sec-writing/op  vs base                  │
Compaction/sqlite-4   2.712m ±  8%      2.972m ± 137%  +9.59% (p=0.004 n=7)
Compaction/dqlite-4   55.30µ ± 52%      51.30µ ±  41%       ~ (p=0.805 n=7)
Create/sqlite-4       968.0µ ±  2%     1045.0µ ±  11%  +7.95% (p=0.026 n=7)
Create/dqlite-4       19.10µ ±   ∞ ¹    17.60µ ±  43%       ~ (p=0.755 n=5+7)
Delete/sqlite-4       1.053m ± 13%      1.049m ±   9%       ~ (p=0.686 n=7)
Delete/dqlite-4       22.00µ ± 34%      21.30µ ±  18%       ~ (p=0.836 n=6+7)
Get/sqlite-4           0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7)   ²
Get/dqlite-4           0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7)   ²
Lease/sqlite-4         0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7)   ²
Lease/dqlite-4         0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7)   ²
List/sqlite-4          0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7)   ²
List/dqlite-4          0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7)   ²
Update/sqlite-4       990.1µ ±  9%      961.5µ ±  14%       ~ (p=0.902 n=7)
Update/dqlite-4       22.70µ ± 33%      23.20µ ±  44%       ~ (p=1.000 n=7)
geomean                            ³                   -0.23%                 ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │     Before      │                After                 │
                    │      B/op       │     B/op      vs base                │
Compaction/sqlite-4    73.79Ki ± 2%     74.94Ki ± 7%       ~ (p=0.209 n=7)
Compaction/dqlite-4    53.72Ki ± 2%     55.03Ki ± 1%  +2.42% (p=0.004 n=7)
Create/sqlite-4        22.96Ki ± 0%     23.81Ki ± 1%  +3.71% (p=0.001 n=7)
Create/dqlite-4        20.68Ki ±  ∞ ¹   21.56Ki ± 0%  +4.28% (p=0.003 n=5+7)
Delete/sqlite-4        25.69Ki ± 1%     26.54Ki ± 2%  +3.32% (p=0.001 n=7)
Delete/dqlite-4        22.37Ki ± 0%     23.27Ki ± 0%  +4.04% (p=0.001 n=6+7)
Get/sqlite-4           20.61Ki ± 0%     21.17Ki ± 0%  +2.73% (p=0.001 n=7)
Get/dqlite-4           18.59Ki ± 0%     19.15Ki ± 0%  +3.01% (p=0.001 n=7)
Lease/sqlite-4         12.33Ki ± 0%     12.33Ki ± 0%       ~ (p=1.000 n=7)
Lease/dqlite-4         12.33Ki ± 0%     12.33Ki ± 0%       ~ (p=1.000 n=7)
List/sqlite-4         1008.0Ki ± 4%     994.8Ki ± 4%       ~ (p=0.620 n=7)
List/dqlite-4          76.44Ki ± 0%     77.00Ki ± 0%  +0.73% (p=0.001 n=7)
Update/sqlite-4        25.20Ki ± 0%     26.07Ki ± 0%  +3.46% (p=0.001 n=7)
Update/dqlite-4        22.19Ki ± 0%     23.07Ki ± 0%  +3.95% (p=0.001 n=7)
geomean                33.96Ki          34.73Ki       +2.26%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    Before     │                 After                 │
                    │   allocs/op   │  allocs/op   vs base                  │
Compaction/sqlite-4   3.267k ± 3%     3.321k ± 7%       ~ (p=0.209 n=7)
Compaction/dqlite-4   1.483k ± 1%     1.516k ± 2%  +2.23% (p=0.002 n=7)
Create/sqlite-4        526.0 ± 0%      535.0 ± 1%  +1.71% (p=0.001 n=7)
Create/dqlite-4        389.0 ±  ∞ ¹    398.0 ± 0%  +2.31% (p=0.003 n=5+7)
Delete/sqlite-4        626.0 ± 2%      635.0 ± 2%  +1.44% (p=0.015 n=7)
Delete/dqlite-4        411.5 ± 0%      422.0 ± 0%  +2.55% (p=0.001 n=6+7)
Get/sqlite-4           499.0 ± 0%      504.0 ± 0%  +1.00% (p=0.001 n=7)
Get/dqlite-4           354.0 ± 0%      359.0 ± 0%  +1.41% (p=0.001 n=7)
Lease/sqlite-4         224.0 ± 0%      224.0 ± 0%       ~ (p=1.000 n=7)   ²
Lease/dqlite-4         224.0 ± 0%      224.0 ± 0%       ~ (p=1.000 n=7)   ²
List/sqlite-4         40.98k ± 5%     40.32k ± 4%       ~ (p=0.594 n=7)
List/dqlite-4         1.699k ± 0%     1.704k ± 0%  +0.29% (p=0.001 n=7)
Update/sqlite-4        602.0 ± 0%      612.0 ± 1%  +1.66% (p=0.001 n=7)
Update/dqlite-4        409.0 ± 0%      418.0 ± 0%  +2.20% (p=0.001 n=7)
geomean                792.9           802.4       +1.20%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
Current status 
goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                    │    After     │
                    │    sec/op    │
Compaction/sqlite-4   4.042m ± 99%
Compaction/dqlite-4   5.346m ± 10%
Create/sqlite-4       1.519m ±  7%
Create/dqlite-4       1.449m ±  3%
Delete/sqlite-4       1.568m ±  6%
Delete/dqlite-4       1.500m ±  3%
Get/sqlite-4          385.4µ ±  1%
Get/dqlite-4          504.9µ ±  1%
Lease/sqlite-4        107.9µ ±  4%
Lease/dqlite-4        109.9µ ±  3%
List/sqlite-4         7.453m ±  3%
List/dqlite-4         43.59m ±  0%
Update/sqlite-4       1.503m ± 10%
Update/dqlite-4       1.510m ±  6%
geomean               1.455m

                    │        After         │
                    │ page-cache-misses/op │
Compaction/sqlite-4           0.000 ± 0%
Compaction/dqlite-4           0.000 ± 0%
Create/sqlite-4               0.000 ± 0%
Create/dqlite-4               0.000 ± 0%
Delete/sqlite-4               0.000 ± 0%
Delete/dqlite-4               0.000 ± 0%
Get/sqlite-4                  0.000 ± 0%
Get/dqlite-4                  0.000 ± 0%
Lease/sqlite-4                0.000 ± 0%
Lease/dqlite-4                0.000 ± 0%
List/sqlite-4                 0.000 ± 0%
List/dqlite-4                 0.000 ± 0%
Update/sqlite-4               0.000 ± 0%
Update/dqlite-4               0.000 ± 0%
geomean                                  ¹
¹ summaries must be >0 to compute geomean

                    │        After         │
                    │ page-cache-spills/op │
Compaction/sqlite-4           0.000 ± 0%
Compaction/dqlite-4           0.000 ± 0%
Create/sqlite-4               0.000 ± 0%
Create/dqlite-4               0.000 ± 0%
Delete/sqlite-4               0.000 ± 0%
Delete/dqlite-4               0.000 ± 0%
Get/sqlite-4                  0.000 ± 0%
Get/dqlite-4                  0.000 ± 0%
Lease/sqlite-4                0.000 ± 0%
Lease/dqlite-4                0.000 ± 0%
List/sqlite-4                 0.000 ± 0%
List/dqlite-4                 0.000 ± 0%
Update/sqlite-4               0.000 ± 0%
Update/dqlite-4               0.000 ± 0%
geomean                                  ¹
¹ summaries must be >0 to compute geomean

                    │     After     │
                    │ page-reads/op │
Compaction/sqlite-4     110.6 ±  3%
Compaction/dqlite-4     119.3 ±  1%
Create/sqlite-4         21.22 ±  2%
Create/dqlite-4         18.19 ±  3%
Delete/sqlite-4         25.16 ±  2%
Delete/dqlite-4         21.12 ±  2%
Get/sqlite-4            11.99 ±  0%
Get/dqlite-4            11.99 ±  0%
Lease/sqlite-4         1.200m ± 47%
Lease/dqlite-4         800.0µ ± 25%
List/sqlite-4           265.0 ±  3%
List/dqlite-4           34.03 ±  0%
Update/sqlite-4         24.90 ±  3%
Update/dqlite-4         21.37 ±  2%
geomean                 7.503

                    │     After      │
                    │ page-writes/op │
Compaction/sqlite-4     11.25 ± 0%
Compaction/dqlite-4     8.282 ± 1%
Create/sqlite-4         5.113 ± 1%
Create/dqlite-4         4.147 ± 1%
Delete/sqlite-4         5.294 ± 1%
Delete/dqlite-4         4.314 ± 1%
Get/sqlite-4            0.000 ± 0%
Get/dqlite-4            0.000 ± 0%
Lease/sqlite-4          0.000 ± 0%
Lease/dqlite-4          0.000 ± 0%
List/sqlite-4           0.000 ± 0%
List/dqlite-4           0.000 ± 0%
Update/sqlite-4         5.141 ± 1%
Update/dqlite-4         4.156 ± 0%
geomean                            ¹
¹ summaries must be >0 to compute geomean

                    │      After      │
                    │ sec-reading/op  │
Compaction/sqlite-4   799.3µ ± 494%
Compaction/dqlite-4   211.6µ ±  18%
Create/sqlite-4       105.4µ ± 111%
Create/dqlite-4       36.50µ ±  66%
Delete/sqlite-4       163.2µ ± 191%
Delete/dqlite-4       52.50µ ±  42%
Get/sqlite-4          88.60µ ±   6%
Get/dqlite-4          35.30µ ±  16%
Lease/sqlite-4         0.000 ±    ?
Lease/dqlite-4         0.000 ±   0%
List/sqlite-4         6.777m ±   4%
List/dqlite-4         260.0µ ±  58%
Update/sqlite-4       179.4µ ±  45%
Update/dqlite-4       93.40µ ±  13%
geomean                             ¹
¹ summaries must be >0 to compute geomean

                    │      After      │
                    │ sec-writing/op  │
Compaction/sqlite-4   2.972m ± 137%
Compaction/dqlite-4   51.30µ ±  41%
Create/sqlite-4       1.045m ±  11%
Create/dqlite-4       17.60µ ±  43%
Delete/sqlite-4       1.049m ±   9%
Delete/dqlite-4       21.30µ ±  18%
Get/sqlite-4           0.000 ±   0%
Get/dqlite-4           0.000 ±   0%
Lease/sqlite-4         0.000 ±   0%
Lease/dqlite-4         0.000 ±   0%
List/sqlite-4          0.000 ±   0%
List/dqlite-4          0.000 ±   0%
Update/sqlite-4       961.5µ ±  14%
Update/dqlite-4       23.20µ ±  44%
geomean                             ¹
¹ summaries must be >0 to compute geomean

                    │    After     │
                    │     B/op     │
Compaction/sqlite-4   74.94Ki ± 7%
Compaction/dqlite-4   55.03Ki ± 1%
Create/sqlite-4       23.81Ki ± 1%
Create/dqlite-4       21.56Ki ± 0%
Delete/sqlite-4       26.54Ki ± 2%
Delete/dqlite-4       23.27Ki ± 0%
Get/sqlite-4          21.17Ki ± 0%
Get/dqlite-4          19.15Ki ± 0%
Lease/sqlite-4        12.33Ki ± 0%
Lease/dqlite-4        12.33Ki ± 0%
List/sqlite-4         994.8Ki ± 4%
List/dqlite-4         77.00Ki ± 0%
Update/sqlite-4       26.07Ki ± 0%
Update/dqlite-4       23.07Ki ± 0%
geomean               34.73Ki

                    │    After    │
                    │  allocs/op  │
Compaction/sqlite-4   3.321k ± 7%
Compaction/dqlite-4   1.516k ± 2%
Create/sqlite-4        535.0 ± 1%
Create/dqlite-4        398.0 ± 0%
Delete/sqlite-4        635.0 ± 2%
Delete/dqlite-4        422.0 ± 0%
Get/sqlite-4           504.0 ± 0%
Get/dqlite-4           359.0 ± 0%
Lease/sqlite-4         224.0 ± 0%
Lease/dqlite-4         224.0 ± 0%
List/sqlite-4         40.32k ± 4%
List/dqlite-4         1.704k ± 0%
Update/sqlite-4        612.0 ± 1%
Update/dqlite-4        418.0 ± 0%
geomean                802.4

marco6
marco6 requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@marco6 marco6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes Louise! Below few comments:

pkg/kine/drivers/sqlite/schema.go Outdated Show resolved Hide resolved
pkg/kine/drivers/sqlite/sqlite.go Outdated Show resolved Hide resolved
pkg/kine/drivers/sqlite/sqlite.go Outdated Show resolved Hide resolved
@marco6 marco6 mentioned this pull request Jul 24, 2024
Draft
@louiseschmidtgen louiseschmidtgen marked this pull request as ready for review July 24, 2024 12:06
@louiseschmidtgen louiseschmidtgen requested a review from a team as a code owner July 24, 2024 12:06
marco6
marco6 requested changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@marco6 marco6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! One more pass:

pkg/kine/drivers/sqlite/schema.go Outdated Show resolved Hide resolved
pkg/kine/drivers/sqlite/schema.go Outdated Show resolved Hide resolved
pkg/kine/drivers/sqlite/schema.go Outdated Show resolved Hide resolved
pkg/kine/drivers/sqlite/schema.go Outdated Show resolved Hide resolved
pkg/kine/drivers/sqlite/sqlite.go Outdated Show resolved Hide resolved
pkg/kine/drivers/sqlite/sqlite.go Show resolved Hide resolved
pkg/kine/drivers/sqlite/sqlite.go Outdated Show resolved Hide resolved
pkg/kine/drivers/sqlite/sqlite.go Outdated Show resolved Hide resolved
pkg/kine/drivers/sqlite/sqlite.go Outdated Show resolved Hide resolved
marco6
marco6 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@marco6 marco6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louiseschmidtgen louiseschmidtgen merged commit 6a3dd4a into master Jul 26, 2024
7 checks passed
@marco6 marco6 deleted the KU-1159/schema-updates branch July 26, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco6 marco6 marco6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louiseschmidtgen @marco6