Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqllog otel traces #143

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Sqllog otel traces #143

merged 2 commits into from
Jul 26, 2024

Conversation

louiseschmidtgen
Copy link
Contributor

Description

This PR adds further otel traces to sqllog functions.

@louiseschmidtgen louiseschmidtgen requested a review from a team as a code owner July 25, 2024 13:22
@louiseschmidtgen louiseschmidtgen requested review from marco6 and removed request for a team July 25, 2024 13:22
@louiseschmidtgen louiseschmidtgen changed the title Sqllog otel races Sqllog otel traces Jul 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Benchmark Result

goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                    │   Before    │                After                │
                    │   sec/op    │    sec/op      vs base              │
Compaction/sqlite-4   3.185m ± 4%   3.222m ± 245%  +1.16% (p=0.038 n=7)
Compaction/dqlite-4   4.871m ± 3%   4.913m ±   2%       ~ (p=0.165 n=7)
Create/sqlite-4       1.291m ± 2%   1.280m ±   4%       ~ (p=0.902 n=7)
Create/dqlite-4       1.301m ± 3%   1.310m ±   3%       ~ (p=0.902 n=7)
Delete/sqlite-4       1.325m ± 2%   1.331m ±   2%       ~ (p=0.456 n=7)
Delete/dqlite-4       1.321m ± 3%   1.323m ±   3%       ~ (p=1.000 n=7)
Get/sqlite-4          394.3µ ± 1%   392.0µ ±   1%  -0.59% (p=0.017 n=7)
Get/dqlite-4          512.4µ ± 0%   511.0µ ±   0%  -0.26% (p=0.026 n=7)
Lease/sqlite-4        109.0µ ± 2%   110.1µ ±   5%       ~ (p=0.383 n=7)
Lease/dqlite-4        110.7µ ± 0%   111.1µ ±   5%       ~ (p=1.000 n=7)
List/sqlite-4         7.605m ± 3%   7.708m ±   6%       ~ (p=0.805 n=7)
List/dqlite-4         43.56m ± 0%   43.60m ±   0%  +0.10% (p=0.038 n=7)
Update/sqlite-4       1.344m ± 5%   1.348m ±   3%       ~ (p=0.456 n=7)
Update/dqlite-4       1.368m ± 3%   1.335m ±   5%       ~ (p=0.318 n=7)
geomean               1.351m        1.354m         +0.18%

                    │        Before        │                    After                     │
                    │ page-cache-misses/op │ page-cache-misses/op  vs base                │
Compaction/sqlite-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4                0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-4                 0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-4                 0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                  ²                         +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │        Before        │                    After                     │
                    │ page-cache-spills/op │ page-cache-spills/op  vs base                │
Compaction/sqlite-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4                0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-4                 0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-4                 0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                  ²                         +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │    Before     │                 After                 │
                    │ page-reads/op │ page-reads/op  vs base                │
Compaction/sqlite-4     106.1 ±  1%     107.0 ± 19%       ~ (p=0.078 n=7)
Compaction/dqlite-4     117.2 ±  3%     117.6 ±  1%  +0.34% (p=0.008 n=7)
Create/sqlite-4         21.58 ±  0%     21.54 ±  0%       ~ (p=0.135 n=7)
Create/dqlite-4         18.75 ±  1%     18.69 ±  2%       ~ (p=0.334 n=7)
Delete/sqlite-4         25.21 ±  1%     25.22 ±  0%       ~ (p=0.915 n=7)
Delete/dqlite-4         21.86 ±  1%     21.81 ±  1%       ~ (p=0.710 n=7)
Get/sqlite-4            11.99 ±  0%     12.00 ±  0%       ~ (p=0.592 n=7)
Get/dqlite-4            11.99 ±  0%     11.99 ±  0%       ~ (p=0.559 n=7)
Lease/sqlite-4         800.0µ ± 50%   1200.0µ ± 50%       ~ (p=0.645 n=7)
Lease/dqlite-4         800.0µ ± 50%    800.0µ ± 50%       ~ (p=0.364 n=7)
List/sqlite-4           270.0 ±  3%     270.0 ±  6%       ~ (p=0.351 n=7)
List/dqlite-4           34.03 ±  0%     34.03 ±  0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4         25.37 ±  1%     25.36 ±  1%       ~ (p=0.972 n=7)
Update/dqlite-4         21.25 ±  3%     22.26 ±  2%  +4.75% (p=0.001 n=7)
geomean                 7.318           7.561        +3.32%
¹ all samples are equal

                    │     Before     │                 After                  │
                    │ page-writes/op │ page-writes/op  vs base                │
Compaction/sqlite-4     11.24 ± 0%         11.24 ± 0%       ~ (p=0.543 n=7)
Compaction/dqlite-4     8.271 ± 0%         8.255 ± 0%       ~ (p=0.440 n=7)
Create/sqlite-4         5.132 ± 0%         5.135 ± 0%       ~ (p=0.079 n=7)
Create/dqlite-4         4.146 ± 0%         4.146 ± 0%       ~ (p=0.434 n=7)
Delete/sqlite-4         5.290 ± 0%         5.290 ± 0%       ~ (p=0.781 n=7)
Delete/dqlite-4         4.313 ± 0%         4.320 ± 0%       ~ (p=0.198 n=7)
Get/sqlite-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4          0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4          0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-4           0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-4           0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4         5.139 ± 0%         5.138 ± 0%       ~ (p=0.540 n=7)
Update/dqlite-4         4.156 ± 0%         4.157 ± 0%       ~ (p=0.132 n=7)
geomean                            ²                   +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │     Before     │                 After                  │
                    │ sec-reading/op │ sec-reading/op  vs base                │
Compaction/sqlite-4   783.2µ ± 23%      758.3µ ± 527%       ~ (p=1.000 n=7)
Compaction/dqlite-4   183.1µ ± 27%      194.3µ ±  35%       ~ (p=0.805 n=7)
Create/sqlite-4       95.90µ ± 16%      99.20µ ±  16%       ~ (p=0.535 n=7)
Create/dqlite-4       45.90µ ± 52%      44.90µ ±  30%       ~ (p=0.782 n=7)
Delete/sqlite-4       145.7µ ± 38%      140.0µ ±  20%       ~ (p=0.596 n=7)
Delete/dqlite-4       43.70µ ± 24%      47.40µ ±  38%  +8.47% (p=0.015 n=7)
Get/sqlite-4          88.50µ ±  5%      91.70µ ±  13%       ~ (p=0.976 n=7)
Get/dqlite-4          35.60µ ± 15%      39.00µ ±   5%  +9.55% (p=0.024 n=7)
Lease/sqlite-4         0.000 ±   ?       0.000 ±   0%       ~ (p=0.462 n=7)
Lease/dqlite-4         0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7) ¹
List/sqlite-4         6.761m ±  3%      6.869m ±   6%       ~ (p=1.000 n=7)
List/dqlite-4         610.0µ ± 23%      640.0µ ±  13%       ~ (p=1.000 n=7)
Update/sqlite-4       185.3µ ± 19%      170.4µ ±  14%       ~ (p=0.097 n=7)
Update/dqlite-4       101.9µ ± 12%      104.0µ ±  21%       ~ (p=0.620 n=7)
geomean                            ²                   +1.49%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │     Before     │                 After                  │
                    │ sec-writing/op │ sec-writing/op  vs base                │
Compaction/sqlite-4   2.143m ±  8%      2.231m ± 340%  +4.11% (p=0.007 n=7)
Compaction/dqlite-4   56.10µ ± 47%      59.70µ ±  44%       ~ (p=0.620 n=7)
Create/sqlite-4       788.3µ ±  4%      784.0µ ±   5%       ~ (p=1.000 n=7)
Create/dqlite-4       22.00µ ± 38%      21.10µ ±  19%       ~ (p=0.902 n=7)
Delete/sqlite-4       819.6µ ±  4%      803.8µ ±   4%       ~ (p=0.383 n=7)
Delete/dqlite-4       23.10µ ± 22%      23.30µ ±  26%       ~ (p=0.644 n=7)
Get/sqlite-4           0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4           0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4         0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4         0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7) ¹
List/sqlite-4          0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7) ¹
List/dqlite-4          0.000 ±  0%       0.000 ±   0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4       775.3µ ± 11%      784.1µ ±   7%       ~ (p=0.710 n=7)
Update/dqlite-4       20.00µ ± 38%      22.50µ ±  18%       ~ (p=0.137 n=7)
geomean                            ²                   +1.25%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │    Before     │                After                 │
                    │     B/op      │      B/op       vs base              │
Compaction/sqlite-4    71.85Ki ± 2%    71.64Ki ± 25%       ~ (p=0.837 n=7)
Compaction/dqlite-4    53.30Ki ± 1%    53.43Ki ±  1%       ~ (p=0.259 n=7)
Create/sqlite-4        22.92Ki ± 0%    23.81Ki ±  0%  +3.86% (p=0.001 n=7)
Create/dqlite-4        20.68Ki ± 0%    21.55Ki ±  0%  +4.22% (p=0.001 n=7)
Delete/sqlite-4        25.65Ki ± 0%    26.53Ki ±  0%  +3.43% (p=0.001 n=7)
Delete/dqlite-4        22.31Ki ± 2%    23.19Ki ±  0%  +3.93% (p=0.001 n=7)
Get/sqlite-4           20.61Ki ± 0%    21.17Ki ±  0%  +2.73% (p=0.001 n=7)
Get/dqlite-4           18.59Ki ± 0%    19.15Ki ±  0%  +3.01% (p=0.001 n=7)
Lease/sqlite-4         12.33Ki ± 0%    12.33Ki ±  0%       ~ (p=0.364 n=7)
Lease/dqlite-4         12.33Ki ± 0%    12.33Ki ±  0%       ~ (p=1.000 n=7)
List/sqlite-4         1018.3Ki ± 3%   1014.8Ki ±  5%       ~ (p=0.318 n=7)
List/dqlite-4          76.42Ki ± 0%    77.00Ki ±  0%  +0.76% (p=0.001 n=7)
Update/sqlite-4        25.18Ki ± 0%    26.05Ki ±  0%  +3.49% (p=0.001 n=7)
Update/dqlite-4        22.18Ki ± 0%    23.05Ki ±  0%  +3.95% (p=0.001 n=7)
geomean                33.88Ki         34.58Ki        +2.06%

                    │   Before    │                After                 │
                    │  allocs/op  │  allocs/op    vs base                │
Compaction/sqlite-4   3.184k ± 2%   3.175k ± 25%       ~ (p=0.902 n=7)
Compaction/dqlite-4   1.472k ± 1%   1.472k ±  1%       ~ (p=1.000 n=7)
Create/sqlite-4        526.0 ± 0%    536.0 ±  0%  +1.90% (p=0.001 n=7)
Create/dqlite-4        389.0 ± 0%    399.0 ±  0%  +2.57% (p=0.001 n=7)
Delete/sqlite-4        627.0 ± 1%    637.0 ±  0%  +1.59% (p=0.001 n=7)
Delete/dqlite-4        411.0 ± 3%    421.0 ±  0%  +2.43% (p=0.001 n=7)
Get/sqlite-4           499.0 ± 0%    504.0 ±  0%  +1.00% (p=0.001 n=7)
Get/dqlite-4           354.0 ± 0%    359.0 ±  0%  +1.41% (p=0.001 n=7)
Lease/sqlite-4         224.0 ± 0%    224.0 ±  0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4         224.0 ± 0%    224.0 ±  0%       ~ (p=1.000 n=7) ¹
List/sqlite-4         41.47k ± 3%   41.28k ±  5%       ~ (p=0.318 n=7)
List/dqlite-4         1.699k ± 0%   1.704k ±  0%  +0.29% (p=0.001 n=7)
Update/sqlite-4        603.0 ± 0%    613.0 ±  0%  +1.66% (p=0.001 n=7)
Update/dqlite-4        409.0 ± 0%    419.0 ±  0%  +2.44% (p=0.001 n=7)
geomean                791.8         800.0        +1.04%
¹ all samples are equal
Current status 
goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                    │     After     │
                    │    sec/op     │
Compaction/sqlite-4   3.222m ± 245%
Compaction/dqlite-4   4.913m ±   2%
Create/sqlite-4       1.280m ±   4%
Create/dqlite-4       1.310m ±   3%
Delete/sqlite-4       1.331m ±   2%
Delete/dqlite-4       1.323m ±   3%
Get/sqlite-4          392.0µ ±   1%
Get/dqlite-4          511.0µ ±   0%
Lease/sqlite-4        110.1µ ±   5%
Lease/dqlite-4        111.1µ ±   5%
List/sqlite-4         7.708m ±   6%
List/dqlite-4         43.60m ±   0%
Update/sqlite-4       1.348m ±   3%
Update/dqlite-4       1.335m ±   5%
geomean               1.354m

                    │        After         │
                    │ page-cache-misses/op │
Compaction/sqlite-4           0.000 ± 0%
Compaction/dqlite-4           0.000 ± 0%
Create/sqlite-4               0.000 ± 0%
Create/dqlite-4               0.000 ± 0%
Delete/sqlite-4               0.000 ± 0%
Delete/dqlite-4               0.000 ± 0%
Get/sqlite-4                  0.000 ± 0%
Get/dqlite-4                  0.000 ± 0%
Lease/sqlite-4                0.000 ± 0%
Lease/dqlite-4                0.000 ± 0%
List/sqlite-4                 0.000 ± 0%
List/dqlite-4                 0.000 ± 0%
Update/sqlite-4               0.000 ± 0%
Update/dqlite-4               0.000 ± 0%
geomean                                  ¹
¹ summaries must be >0 to compute geomean

                    │        After         │
                    │ page-cache-spills/op │
Compaction/sqlite-4           0.000 ± 0%
Compaction/dqlite-4           0.000 ± 0%
Create/sqlite-4               0.000 ± 0%
Create/dqlite-4               0.000 ± 0%
Delete/sqlite-4               0.000 ± 0%
Delete/dqlite-4               0.000 ± 0%
Get/sqlite-4                  0.000 ± 0%
Get/dqlite-4                  0.000 ± 0%
Lease/sqlite-4                0.000 ± 0%
Lease/dqlite-4                0.000 ± 0%
List/sqlite-4                 0.000 ± 0%
List/dqlite-4                 0.000 ± 0%
Update/sqlite-4               0.000 ± 0%
Update/dqlite-4               0.000 ± 0%
geomean                                  ¹
¹ summaries must be >0 to compute geomean

                    │     After     │
                    │ page-reads/op │
Compaction/sqlite-4     107.0 ± 19%
Compaction/dqlite-4     117.6 ±  1%
Create/sqlite-4         21.54 ±  0%
Create/dqlite-4         18.69 ±  2%
Delete/sqlite-4         25.22 ±  0%
Delete/dqlite-4         21.81 ±  1%
Get/sqlite-4            12.00 ±  0%
Get/dqlite-4            11.99 ±  0%
Lease/sqlite-4         1.200m ± 50%
Lease/dqlite-4         800.0µ ± 50%
List/sqlite-4           270.0 ±  6%
List/dqlite-4           34.03 ±  0%
Update/sqlite-4         25.36 ±  1%
Update/dqlite-4         22.26 ±  2%
geomean                 7.561

                    │     After      │
                    │ page-writes/op │
Compaction/sqlite-4     11.24 ± 0%
Compaction/dqlite-4     8.255 ± 0%
Create/sqlite-4         5.135 ± 0%
Create/dqlite-4         4.146 ± 0%
Delete/sqlite-4         5.290 ± 0%
Delete/dqlite-4         4.320 ± 0%
Get/sqlite-4            0.000 ± 0%
Get/dqlite-4            0.000 ± 0%
Lease/sqlite-4          0.000 ± 0%
Lease/dqlite-4          0.000 ± 0%
List/sqlite-4           0.000 ± 0%
List/dqlite-4           0.000 ± 0%
Update/sqlite-4         5.138 ± 0%
Update/dqlite-4         4.157 ± 0%
geomean                            ¹
¹ summaries must be >0 to compute geomean

                    │      After      │
                    │ sec-reading/op  │
Compaction/sqlite-4   758.3µ ± 527%
Compaction/dqlite-4   194.3µ ±  35%
Create/sqlite-4       99.20µ ±  16%
Create/dqlite-4       44.90µ ±  30%
Delete/sqlite-4       140.0µ ±  20%
Delete/dqlite-4       47.40µ ±  38%
Get/sqlite-4          91.70µ ±  13%
Get/dqlite-4          39.00µ ±   5%
Lease/sqlite-4         0.000 ±   0%
Lease/dqlite-4         0.000 ±   0%
List/sqlite-4         6.869m ±   6%
List/dqlite-4         640.0µ ±  13%
Update/sqlite-4       170.4µ ±  14%
Update/dqlite-4       104.0µ ±  21%
geomean                             ¹
¹ summaries must be >0 to compute geomean

                    │      After      │
                    │ sec-writing/op  │
Compaction/sqlite-4   2.231m ± 340%
Compaction/dqlite-4   59.70µ ±  44%
Create/sqlite-4       784.0µ ±   5%
Create/dqlite-4       21.10µ ±  19%
Delete/sqlite-4       803.8µ ±   4%
Delete/dqlite-4       23.30µ ±  26%
Get/sqlite-4           0.000 ±   0%
Get/dqlite-4           0.000 ±   0%
Lease/sqlite-4         0.000 ±   0%
Lease/dqlite-4         0.000 ±   0%
List/sqlite-4          0.000 ±   0%
List/dqlite-4          0.000 ±   0%
Update/sqlite-4       784.1µ ±   7%
Update/dqlite-4       22.50µ ±  18%
geomean                             ¹
¹ summaries must be >0 to compute geomean

                    │     After      │
                    │      B/op      │
Compaction/sqlite-4    71.64Ki ± 25%
Compaction/dqlite-4    53.43Ki ±  1%
Create/sqlite-4        23.81Ki ±  0%
Create/dqlite-4        21.55Ki ±  0%
Delete/sqlite-4        26.53Ki ±  0%
Delete/dqlite-4        23.19Ki ±  0%
Get/sqlite-4           21.17Ki ±  0%
Get/dqlite-4           19.15Ki ±  0%
Lease/sqlite-4         12.33Ki ±  0%
Lease/dqlite-4         12.33Ki ±  0%
List/sqlite-4         1014.8Ki ±  5%
List/dqlite-4          77.00Ki ±  0%
Update/sqlite-4        26.05Ki ±  0%
Update/dqlite-4        23.05Ki ±  0%
geomean                34.58Ki

                    │    After     │
                    │  allocs/op   │
Compaction/sqlite-4   3.175k ± 25%
Compaction/dqlite-4   1.472k ±  1%
Create/sqlite-4        536.0 ±  0%
Create/dqlite-4        399.0 ±  0%
Delete/sqlite-4        637.0 ±  0%
Delete/dqlite-4        421.0 ±  0%
Get/sqlite-4           504.0 ±  0%
Get/dqlite-4           359.0 ±  0%
Lease/sqlite-4         224.0 ±  0%
Lease/dqlite-4         224.0 ±  0%
List/sqlite-4         41.28k ±  5%
List/dqlite-4         1.704k ±  0%
Update/sqlite-4        613.0 ±  0%
Update/dqlite-4        419.0 ±  0%
geomean                800.0

addyess
addyess reviewed Jul 25, 2024
View reviewed changes
Copy link

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one place where it seems attributes were missing. Was that intentional?

pkg/kine/logstructured/sqllog/sql.go Outdated Show resolved Hide resolved
addyess
addyess approved these changes Jul 25, 2024
View reviewed changes
Copy link

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@addyess
Copy link

addyess commented Jul 25, 2024

thanks @marco6 if you can agree!

@louiseschmidtgen louiseschmidtgen merged commit 8286d77 into master Jul 26, 2024
7 checks passed
@louiseschmidtgen louiseschmidtgen deleted the KU-1099/provoke-compaction-failure branch August 12, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addyess addyess addyess approved these changes

@marco6 marco6 Awaiting requested review from marco6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louiseschmidtgen @addyess