Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

back-port: [v1.2] Fix memory leak watch context cancel (#240) #243

Merged
merged 1 commit into from
Feb 12, 2025
Merged

back-port: [v1.2] Fix memory leak watch context cancel (#240) #243

merged 1 commit into from
Feb 12, 2025

Conversation

louiseschmidtgen
Copy link
Contributor

Description

Back-port of #240

@louiseschmidtgen louiseschmidtgen requested a review from a team as a code owner February 11, 2025 12:52
@louiseschmidtgen louiseschmidtgen changed the title bug: Fix memory leak watch context cancel (#240) back-port: [v1.2] Fix memory leak watch context cancel (#240) Feb 11, 2025
@github-actions GitHub Actions
Copy link

Benchmark Result

goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                                        │    Before     │                After                │
                                        │    sec/op     │    sec/op     vs base               │
Compaction/sqlite-4                        40.65µ ± 14%   40.98µ ± 22%        ~ (p=0.620 n=7)
Compaction/dqlite-4                        57.51µ ± 15%   59.37µ ±  6%        ~ (p=0.053 n=7)
Create/sqlite-4                            1.681m ± 31%   1.450m ±  8%        ~ (p=0.053 n=7)
Create/dqlite-4                            1.521m ± 10%   1.295m ± 10%  -14.84% (p=0.002 n=7)
Delete/sqlite-4                            1.823m ± 10%   1.816m ±  8%        ~ (p=0.620 n=7)
Delete/dqlite-4                            1.660m ± 10%   1.607m ± 13%        ~ (p=0.535 n=7)
Get/sqlite-4                               256.5µ ±  1%   248.9µ ±  1%   -2.97% (p=0.001 n=7)
Get/dqlite-4                               352.0µ ±  1%   341.9µ ±  1%   -2.85% (p=0.001 n=7)
Lease/sqlite-4                            101.84µ ±  5%   98.02µ ±  2%   -3.75% (p=0.001 n=7)
Lease/dqlite-4                            101.65µ ±  1%   98.75µ ±  3%   -2.85% (p=0.002 n=7)
List/sqlite-tiny/all-4                     4.137µ ±  2%   4.141µ ±  5%        ~ (p=0.932 n=7)
List/sqlite-tiny/pagination-4              6.872µ ±  5%   6.687µ ±  6%        ~ (p=0.175 n=7)
List/sqlite-fits-in-page/all-4             6.910µ ±  1%   6.822µ ±  4%        ~ (p=0.535 n=7)
List/sqlite-fits-in-page/pagination-4      17.69µ ±  3%   18.11µ ±  2%   +2.35% (p=0.017 n=7)
List/sqlite-overflows-page/all-4           16.69µ ±  3%   16.61µ ±  4%        ~ (p=0.128 n=7)
List/sqlite-overflows-page/pagination-4    25.65µ ±  7%   25.42µ ±  4%        ~ (p=1.000 n=7)
List/dqlite-tiny/all-4                     2.363µ ±  2%   2.333µ ±  4%        ~ (p=0.259 n=7)
List/dqlite-tiny/pagination-4              4.164µ ±  2%   4.122µ ±  3%        ~ (p=0.456 n=7)
List/dqlite-fits-in-page/all-4             5.451µ ±  4%   5.259µ ±  2%   -3.52% (p=0.007 n=7)
List/dqlite-fits-in-page/pagination-4      12.68µ ±  3%   12.40µ ±  4%   -2.21% (p=0.007 n=7)
List/dqlite-overflows-page/all-4           16.92µ ±  3%   16.92µ ±  2%        ~ (p=0.805 n=7)
List/dqlite-overflows-page/pagination-4    22.54µ ±  4%   23.39µ ±  3%   +3.74% (p=0.017 n=7)
Update/sqlite-4                            1.559m ± 10%   1.786m ±  8%  +14.54% (p=0.001 n=7)
Update/dqlite-4                            1.563m ± 11%   1.508m ± 22%        ~ (p=0.165 n=7)
geomean                                    63.10µ         62.05µ         -1.67%

                                        │        Before        │                    After                     │
                                        │ page-cache-misses/op │ page-cache-misses/op  vs base                │
Compaction/sqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4                                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                                      ²                         +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │        Before        │                    After                     │
                                        │ page-cache-spills/op │ page-cache-spills/op  vs base                │
Compaction/sqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Compaction/dqlite-4                               0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Create/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Delete/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/sqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                      0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4                                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                            0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4                     0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4                    0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4                  0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4           0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/dqlite-4                                   0.000 ± 0%               0.000 ± 0%       ~ (p=1.000 n=7) ¹
geomean                                                      ²                         +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │    Before     │                After                 │
                                        │ page-reads/op │ page-reads/op  vs base               │
Compaction/sqlite-4                         12.14 ±  1%     12.17 ±  2%        ~ (p=0.826 n=7)
Compaction/dqlite-4                         12.18 ±  2%     12.21 ±  1%        ~ (p=0.368 n=7)
Create/sqlite-4                             13.64 ±  3%     13.96 ±  3%        ~ (p=0.329 n=7)
Create/dqlite-4                             12.72 ±  2%     12.89 ±  1%   +1.34% (p=0.007 n=7)
Delete/sqlite-4                             24.88 ±  5%     24.68 ±  6%        ~ (p=0.773 n=7)
Delete/dqlite-4                             23.86 ±  1%     23.76 ±  1%        ~ (p=0.105 n=7)
Get/sqlite-4                                14.96 ± 20%     14.95 ± 20%        ~ (p=0.689 n=7)
Get/dqlite-4                                11.97 ±  0%     11.96 ±  0%        ~ (p=0.570 n=7)
Lease/sqlite-4                             1.333m ± 40%    1.306m ± 62%        ~ (p=0.364 n=7)
Lease/dqlite-4                             800.0µ ± 50%    663.2µ ± 49%  -17.10% (p=0.037 n=7)
List/sqlite-tiny/all-4                     191.9m ±  0%    192.0m ±  0%        ~ (p=0.860 n=7)
List/sqlite-tiny/pagination-4               1.130 ±  0%     1.130 ±  3%        ~ (p=0.731 n=7)
List/sqlite-fits-in-page/all-4             164.6m ±  0%    164.3m ±  0%        ~ (p=0.159 n=7)
List/sqlite-fits-in-page/pagination-4      963.3m ±  0%    963.4m ±  3%        ~ (p=0.971 n=7)
List/sqlite-overflows-page/all-4           185.9m ±  0%    185.9m ±  0%        ~ (p=0.780 n=7)
List/sqlite-overflows-page/pagination-4     1.076 ±  3%     1.077 ±  0%   +0.09% (p=0.033 n=7)
List/dqlite-tiny/all-4                     190.6m ±  0%    190.6m ±  0%        ~ (p=0.237 n=7)
List/dqlite-tiny/pagination-4               1.125 ±  3%     1.125 ±  3%        ~ (p=1.000 n=7)
List/dqlite-fits-in-page/all-4             163.1m ± 59%    163.1m ± 59%        ~ (p=0.266 n=7)
List/dqlite-fits-in-page/pagination-4      954.4m ±  0%    954.6m ±  0%        ~ (p=0.480 n=7)
List/dqlite-overflows-page/all-4           183.2m ±  0%    183.1m ±  0%        ~ (p=0.584 n=7)
List/dqlite-overflows-page/pagination-4     1.071 ±  0%     1.072 ±  3%        ~ (p=0.720 n=7)
Update/sqlite-4                             24.77 ±  2%     24.45 ±  3%        ~ (p=0.383 n=7)
Update/dqlite-4                             23.82 ±  2%     23.97 ±  3%        ~ (p=0.272 n=7)
geomean                                     1.199           1.189         -0.78%

                                        │     Before     │                 After                  │
                                        │ page-writes/op │ page-writes/op  vs base                │
Compaction/sqlite-4                        207.4m ± 0%        207.9m ± 1%       ~ (p=0.194 n=7)
Compaction/dqlite-4                        187.4m ± 1%        187.7m ± 2%       ~ (p=0.691 n=7)
Create/sqlite-4                             5.105 ± 1%         5.108 ± 0%       ~ (p=0.379 n=7)
Create/dqlite-4                             4.120 ± 0%         4.133 ± 1%  +0.32% (p=0.004 n=7)
Delete/sqlite-4                             5.327 ± 1%         5.316 ± 1%       ~ (p=0.364 n=7)
Delete/dqlite-4                             4.392 ± 0%         4.389 ± 1%       ~ (p=0.397 n=7)
Get/sqlite-4                                0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Get/dqlite-4                                0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/sqlite-4                              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Lease/dqlite-4                              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                      0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4               0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4       0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4     0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                      0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4               0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4              0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4       0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4            0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4     0.000 ± 0%         0.000 ± 0%       ~ (p=1.000 n=7) ¹
Update/sqlite-4                             5.123 ± 1%         5.120 ± 1%       ~ (p=0.737 n=7)
Update/dqlite-4                             4.156 ± 1%         4.160 ± 1%       ~ (p=0.475 n=7)
geomean                                                ²                   +0.02%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │      Before      │                  After                  │
                                        │  sec-reading/op  │ sec-reading/op  vs base                 │
Compaction/sqlite-4                        105.0µ ±  75%      109.7µ ±  19%        ~ (p=0.155 n=7)
Compaction/dqlite-4                        30.60µ ±  48%      34.40µ ±  11%        ~ (p=0.053 n=7)
Create/sqlite-4                            37.30µ ± 247%      36.90µ ± 503%        ~ (p=1.000 n=7)
Create/dqlite-4                            7.700µ ±  83%      8.200µ ± 111%        ~ (p=0.620 n=7)
Delete/sqlite-4                            349.2µ ± 195%      392.4µ ± 262%        ~ (p=0.902 n=7)
Delete/dqlite-4                            51.90µ ±  19%      39.90µ ±  38%  -23.12% (p=0.017 n=7)
Get/sqlite-4                               76.30µ ±   7%      82.60µ ±   4%   +8.26% (p=0.007 n=7)
Get/dqlite-4                               26.30µ ±  21%      23.10µ ±  20%        ~ (p=0.209 n=7)
Lease/sqlite-4                              0.000 ±    ?       0.000 ±    ?        ~ (p=1.000 n=7)
Lease/dqlite-4                              0.000 ±    ?       0.000 ±    ?        ~ (p=1.000 n=7)
List/sqlite-tiny/all-4                     12.30µ ±   3%      12.30µ ±   3%        ~ (p=0.977 n=7)
List/sqlite-tiny/pagination-4              14.80µ ±   5%      14.60µ ±   5%        ~ (p=0.364 n=7)
List/sqlite-fits-in-page/all-4             19.20µ ±  18%      17.20µ ±  34%        ~ (p=0.477 n=7)
List/sqlite-fits-in-page/pagination-4      55.00µ ±   3%      56.10µ ±   2%   +2.00% (p=0.005 n=7)
List/sqlite-overflows-page/all-4           56.40µ ±  17%      52.40µ ±  12%        ~ (p=0.259 n=7)
List/sqlite-overflows-page/pagination-4   150.30µ ±  68%      53.50µ ± 180%  -64.40% (p=0.029 n=7)
List/dqlite-tiny/all-4                     3.300µ ±  18%      3.200µ ±  22%        ~ (p=0.213 n=7)
List/dqlite-tiny/pagination-4              6.000µ ±  18%      5.400µ ±  17%        ~ (p=0.440 n=7)
List/dqlite-fits-in-page/all-4             9.000µ ±  13%      7.800µ ±  13%  -13.33% (p=0.008 n=7)
List/dqlite-fits-in-page/pagination-4      19.00µ ±   9%      18.70µ ±   9%        ~ (p=0.304 n=7)
List/dqlite-overflows-page/all-4           29.20µ ±   3%      29.10µ ±   2%        ~ (p=0.594 n=7)
List/dqlite-overflows-page/pagination-4    38.70µ ±  12%      38.00µ ±  14%        ~ (p=0.303 n=7)
Update/sqlite-4                            185.5µ ± 207%      176.8µ ±  59%        ~ (p=0.535 n=7)
Update/dqlite-4                            108.1µ ±  20%      104.8µ ±  11%        ~ (p=0.902 n=7)
geomean                                                  ¹                    -6.41%               ¹
¹ summaries must be >0 to compute geomean

                                        │     Before     │                  After                  │
                                        │ sec-writing/op │ sec-writing/op  vs base                 │
Compaction/sqlite-4                       9.600µ ±  6%       9.500µ ±  9%        ~ (p=0.922 n=7)
Compaction/dqlite-4                       7.600µ ± 16%       7.800µ ± 10%        ~ (p=0.564 n=7)
Create/sqlite-4                           1.410m ± 37%       1.219m ±  8%  -13.55% (p=0.049 n=7)
Create/dqlite-4                           32.60µ ± 30%       33.70µ ± 18%        ~ (p=0.902 n=7)
Delete/sqlite-4                           1.421m ±  9%       1.442m ± 11%        ~ (p=0.535 n=7)
Delete/dqlite-4                           21.60µ ± 60%       21.80µ ± 46%        ~ (p=1.000 n=7)
Get/sqlite-4                               0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
Get/dqlite-4                               0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
Lease/sqlite-4                             0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
Lease/dqlite-4                             0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                     0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-tiny/pagination-4              0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/all-4             0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-fits-in-page/pagination-4      0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/all-4           0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-overflows-page/pagination-4    0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-tiny/all-4                     0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-tiny/pagination-4              0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/all-4             0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-fits-in-page/pagination-4      0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/all-4           0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
List/dqlite-overflows-page/pagination-4    0.000 ±  0%        0.000 ±  0%        ~ (p=1.000 n=7) ¹
Update/sqlite-4                           1.096m ± 16%       1.343m ± 10%  +22.54% (p=0.001 n=7)
Update/dqlite-4                           18.30µ ± 38%       23.00µ ± 32%        ~ (p=0.121 n=7)
geomean                                                ²                    +1.51%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                        │     Before     │                 After                 │
                                        │      B/op      │      B/op       vs base               │
Compaction/sqlite-4                         405.0 ± 106%      413.0 ± 79%        ~ (p=1.000 n=7)
Compaction/dqlite-4                       8.769Ki ±  49%   11.139Ki ± 18%  +27.03% (p=0.026 n=7)
Create/sqlite-4                           21.40Ki ±   1%    21.23Ki ±  1%   -0.79% (p=0.016 n=7)
Create/dqlite-4                           20.16Ki ±   0%    19.97Ki ±  0%   -0.92% (p=0.001 n=7)
Delete/sqlite-4                           32.41Ki ±   4%    32.07Ki ±  6%        ~ (p=0.259 n=7)
Delete/dqlite-4                           29.50Ki ±   0%    29.35Ki ±  0%   -0.53% (p=0.001 n=7)
Get/sqlite-4                              25.07Ki ±   0%    25.05Ki ±  0%        ~ (p=0.620 n=7)
Get/dqlite-4                              22.89Ki ±   0%    22.89Ki ±  0%   +0.01% (p=0.030 n=7)
Lease/sqlite-4                            12.33Ki ±   0%    12.33Ki ±  0%   -0.02% (p=0.001 n=7)
Lease/dqlite-4                            12.33Ki ±   0%    12.33Ki ±  0%   -0.02% (p=0.004 n=7)
List/sqlite-tiny/all-4                    1.216Ki ±   3%    1.224Ki ±  2%        ~ (p=0.734 n=7)
List/sqlite-tiny/pagination-4             1.543Ki ±   4%    1.520Ki ±  4%        ~ (p=0.456 n=7)
List/sqlite-fits-in-page/all-4            5.021Ki ±   2%    4.933Ki ±  4%        ~ (p=0.154 n=7)
List/sqlite-fits-in-page/pagination-4     9.060Ki ±   4%    9.096Ki ±  3%        ~ (p=0.710 n=7)
List/sqlite-overflows-page/all-4          25.93Ki ±   4%    25.72Ki ±  3%        ~ (p=0.511 n=7)
List/sqlite-overflows-page/pagination-4   33.13Ki ±   7%    33.79Ki ±  7%        ~ (p=0.165 n=7)
List/dqlite-tiny/all-4                      833.0 ±   2%      836.0 ±  4%        ~ (p=0.315 n=7)
List/dqlite-tiny/pagination-4               812.0 ±   1%      805.0 ±  2%        ~ (p=0.244 n=7)
List/dqlite-fits-in-page/all-4            4.268Ki ±   1%    4.236Ki ±  4%   -0.73% (p=0.012 n=7)
List/dqlite-fits-in-page/pagination-4     4.345Ki ±   1%    4.380Ki ±  4%        ~ (p=0.128 n=7)
List/dqlite-overflows-page/all-4          21.31Ki ±   1%    21.13Ki ±  1%        ~ (p=0.535 n=7)
List/dqlite-overflows-page/pagination-4   22.12Ki ±   4%    23.21Ki ±  5%   +4.90% (p=0.017 n=7)
Update/sqlite-4                           30.35Ki ±   2%    30.22Ki ±  1%   -0.42% (p=0.026 n=7)
Update/dqlite-4                           27.66Ki ±   0%    27.48Ki ±  0%   -0.65% (p=0.001 n=7)
geomean                                   8.774Ki           8.861Ki         +1.00%

                                        │    Before    │                After                 │
                                        │  allocs/op   │  allocs/op   vs base                 │
Compaction/sqlite-4                       14.00 ± 121%   14.00 ± 93%        ~ (p=0.878 n=7)
Compaction/dqlite-4                       213.0 ±  50%   268.0 ± 17%  +25.82% (p=0.023 n=7)
Create/sqlite-4                           455.0 ±   2%   454.0 ±  2%        ~ (p=0.315 n=7)
Create/dqlite-4                           371.0 ±   0%   371.0 ±  0%        ~ (p=1.000 n=7) ¹
Delete/sqlite-4                           718.0 ±   5%   712.0 ±  8%        ~ (p=0.597 n=7)
Delete/dqlite-4                           510.0 ±   0%   510.0 ±  0%        ~ (p=0.192 n=7)
Get/sqlite-4                              563.0 ±   0%   563.0 ±  0%        ~ (p=1.000 n=7) ¹
Get/dqlite-4                              407.0 ±   0%   407.0 ±  0%        ~ (p=1.000 n=7) ¹
Lease/sqlite-4                            224.0 ±   0%   224.0 ±  0%        ~ (p=1.000 n=7) ¹
Lease/dqlite-4                            224.0 ±   0%   224.0 ±  0%        ~ (p=1.000 n=7) ¹
List/sqlite-tiny/all-4                    39.00 ±   3%   40.00 ±  5%        ~ (p=1.000 n=7)
List/sqlite-tiny/pagination-4             52.00 ±   4%   52.00 ±  6%        ~ (p=0.348 n=7)
List/sqlite-fits-in-page/all-4            46.00 ±   2%   45.00 ±  4%        ~ (p=0.293 n=7)
List/sqlite-fits-in-page/pagination-4     83.00 ±   4%   83.00 ±  2%        ~ (p=0.674 n=7)
List/sqlite-overflows-page/all-4          55.00 ±   4%   55.00 ±  4%        ~ (p=0.798 n=7)
List/sqlite-overflows-page/pagination-4   69.00 ±   7%   70.00 ±  6%        ~ (p=0.210 n=7)
List/dqlite-tiny/all-4                    13.00 ±   0%   13.00 ±  8%        ~ (p=1.000 n=7)
List/dqlite-tiny/pagination-4             12.00 ±   8%   12.00 ±  8%        ~ (p=1.000 n=7)
List/dqlite-fits-in-page/all-4            18.00 ±   6%   17.00 ±  6%        ~ (p=0.086 n=7)
List/dqlite-fits-in-page/pagination-4     18.00 ±   6%   18.00 ±  6%        ~ (p=0.269 n=7)
List/dqlite-overflows-page/all-4          30.00 ±   3%   29.00 ±  3%        ~ (p=0.592 n=7)
List/dqlite-overflows-page/pagination-4   31.00 ±   6%   33.00 ±  6%   +6.45% (p=0.016 n=7)
Update/sqlite-4                           671.0 ±   3%   670.0 ±  1%        ~ (p=0.410 n=7)
Update/dqlite-4                           491.0 ±   0%   491.0 ±  0%        ~ (p=0.633 n=7)
geomean                                   99.85          100.7         +0.87%
¹ all samples are equal

                                        │        Before         │                    After                     │
                                        │ network-bytes-read/op │ network-bytes-read/op  vs base               │
Compaction/dqlite-4                               3.223Ki ± 50%           4.126Ki ± 18%  +28.03% (p=0.026 n=7)
Create/dqlite-4                                     239.3 ±  0%             239.4 ±  0%        ~ (p=0.107 n=7)
Delete/dqlite-4                                   1.155Ki ±  0%           1.157Ki ±  0%        ~ (p=0.139 n=7)
Get/dqlite-4                                      1.133Ki ±  0%           1.133Ki ±  0%        ~ (p=0.073 n=7)
Lease/dqlite-4                                    0.03280 ± 20%           0.02719 ± 44%        ~ (p=0.122 n=7)
List/dqlite-tiny/all-4                              188.7 ±  2%             189.2 ±  5%        ~ (p=0.398 n=7)
List/dqlite-tiny/pagination-4                       179.6 ±  1%             177.2 ±  2%   -1.34% (p=0.049 n=7)
List/dqlite-fits-in-page/all-4                    1.218Ki ±  2%           1.203Ki ±  6%   -1.20% (p=0.016 n=7)
List/dqlite-fits-in-page/pagination-4             1.232Ki ±  2%           1.228Ki ±  7%        ~ (p=0.535 n=7)
List/dqlite-overflows-page/all-4                  6.273Ki ±  2%           6.190Ki ±  1%        ~ (p=0.535 n=7)
List/dqlite-overflows-page/pagination-4           6.569Ki ±  7%           7.080Ki ±  8%   +7.77% (p=0.026 n=7)
Update/dqlite-4                                     564.0 ±  0%             564.5 ±  0%        ~ (p=0.242 n=7)
geomean                                             435.2                   438.8         +0.81%

                                        │          Before          │                     After                      │
                                        │ network-bytes-written/op │ network-bytes-written/op  vs base              │
Compaction/dqlite-4                                   5.109 ±  13%               5.459 ±  13%  +6.85% (p=0.019 n=7)
Create/dqlite-4                                       112.4 ±   0%               112.5 ±   1%       ~ (p=0.695 n=7)
Delete/dqlite-4                                       423.4 ±   0%               423.5 ±   0%       ~ (p=0.797 n=7)
Get/dqlite-4                                          80.51 ±   0%               80.50 ±   0%  -0.01% (p=0.040 n=7)
Lease/dqlite-4                                      0.01360 ± 341%             0.01127 ± 432%       ~ (p=0.089 n=7)
List/dqlite-tiny/all-4                              0.03715 ±   5%             0.03727 ±  10%       ~ (p=0.383 n=7)
List/dqlite-tiny/pagination-4                       0.03949 ±   7%             0.03723 ±  10%       ~ (p=0.456 n=7)
List/dqlite-fits-in-page/all-4                      0.05131 ±   3%             0.05053 ±  10%  -1.52% (p=0.011 n=7)
List/dqlite-fits-in-page/pagination-4               0.06829 ±  10%             0.06967 ±  10%       ~ (p=0.535 n=7)
List/dqlite-overflows-page/all-4                    0.06494 ±   4%             0.06411 ±   2%       ~ (p=0.710 n=7)
List/dqlite-overflows-page/pagination-4             0.09380 ±  13%             0.09634 ±  19%       ~ (p=0.535 n=7)
Update/dqlite-4                                       263.4 ±   0%               263.5 ±   0%       ~ (p=0.593 n=7)
geomean                                               1.068                      1.054         -1.30%
Current status 
goos: linux
goarch: amd64
pkg: github.com/canonical/k8s-dqlite/test
cpu: AMD EPYC 7763 64-Core Processor                
                                        │    After     │
                                        │    sec/op    │
Compaction/sqlite-4                       40.98µ ± 22%
Compaction/dqlite-4                       59.37µ ±  6%
Create/sqlite-4                           1.450m ±  8%
Create/dqlite-4                           1.295m ± 10%
Delete/sqlite-4                           1.816m ±  8%
Delete/dqlite-4                           1.607m ± 13%
Get/sqlite-4                              248.9µ ±  1%
Get/dqlite-4                              341.9µ ±  1%
Lease/sqlite-4                            98.02µ ±  2%
Lease/dqlite-4                            98.75µ ±  3%
List/sqlite-tiny/all-4                    4.141µ ±  5%
List/sqlite-tiny/pagination-4             6.687µ ±  6%
List/sqlite-fits-in-page/all-4            6.822µ ±  4%
List/sqlite-fits-in-page/pagination-4     18.11µ ±  2%
List/sqlite-overflows-page/all-4          16.61µ ±  4%
List/sqlite-overflows-page/pagination-4   25.42µ ±  4%
List/dqlite-tiny/all-4                    2.333µ ±  4%
List/dqlite-tiny/pagination-4             4.122µ ±  3%
List/dqlite-fits-in-page/all-4            5.259µ ±  2%
List/dqlite-fits-in-page/pagination-4     12.40µ ±  4%
List/dqlite-overflows-page/all-4          16.92µ ±  2%
List/dqlite-overflows-page/pagination-4   23.39µ ±  3%
Update/sqlite-4                           1.786m ±  8%
Update/dqlite-4                           1.508m ± 22%
geomean                                   62.05µ

                                        │        After         │
                                        │ page-cache-misses/op │
Compaction/sqlite-4                               0.000 ± 0%
Compaction/dqlite-4                               0.000 ± 0%
Create/sqlite-4                                   0.000 ± 0%
Create/dqlite-4                                   0.000 ± 0%
Delete/sqlite-4                                   0.000 ± 0%
Delete/dqlite-4                                   0.000 ± 0%
Get/sqlite-4                                      0.000 ± 0%
Get/dqlite-4                                      0.000 ± 0%
Lease/sqlite-4                                    0.000 ± 0%
Lease/dqlite-4                                    0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%
List/sqlite-tiny/pagination-4                     0.000 ± 0%
List/sqlite-fits-in-page/all-4                    0.000 ± 0%
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%
List/sqlite-overflows-page/all-4                  0.000 ± 0%
List/sqlite-overflows-page/pagination-4           0.000 ± 0%
List/dqlite-tiny/all-4                            0.000 ± 0%
List/dqlite-tiny/pagination-4                     0.000 ± 0%
List/dqlite-fits-in-page/all-4                    0.000 ± 0%
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%
List/dqlite-overflows-page/all-4                  0.000 ± 0%
List/dqlite-overflows-page/pagination-4           0.000 ± 0%
Update/sqlite-4                                   0.000 ± 0%
Update/dqlite-4                                   0.000 ± 0%
geomean                                                      ¹
¹ summaries must be >0 to compute geomean

                                        │        After         │
                                        │ page-cache-spills/op │
Compaction/sqlite-4                               0.000 ± 0%
Compaction/dqlite-4                               0.000 ± 0%
Create/sqlite-4                                   0.000 ± 0%
Create/dqlite-4                                   0.000 ± 0%
Delete/sqlite-4                                   0.000 ± 0%
Delete/dqlite-4                                   0.000 ± 0%
Get/sqlite-4                                      0.000 ± 0%
Get/dqlite-4                                      0.000 ± 0%
Lease/sqlite-4                                    0.000 ± 0%
Lease/dqlite-4                                    0.000 ± 0%
List/sqlite-tiny/all-4                            0.000 ± 0%
List/sqlite-tiny/pagination-4                     0.000 ± 0%
List/sqlite-fits-in-page/all-4                    0.000 ± 0%
List/sqlite-fits-in-page/pagination-4             0.000 ± 0%
List/sqlite-overflows-page/all-4                  0.000 ± 0%
List/sqlite-overflows-page/pagination-4           0.000 ± 0%
List/dqlite-tiny/all-4                            0.000 ± 0%
List/dqlite-tiny/pagination-4                     0.000 ± 0%
List/dqlite-fits-in-page/all-4                    0.000 ± 0%
List/dqlite-fits-in-page/pagination-4             0.000 ± 0%
List/dqlite-overflows-page/all-4                  0.000 ± 0%
List/dqlite-overflows-page/pagination-4           0.000 ± 0%
Update/sqlite-4                                   0.000 ± 0%
Update/dqlite-4                                   0.000 ± 0%
geomean                                                      ¹
¹ summaries must be >0 to compute geomean

                                        │     After     │
                                        │ page-reads/op │
Compaction/sqlite-4                         12.17 ±  2%
Compaction/dqlite-4                         12.21 ±  1%
Create/sqlite-4                             13.96 ±  3%
Create/dqlite-4                             12.89 ±  1%
Delete/sqlite-4                             24.68 ±  6%
Delete/dqlite-4                             23.76 ±  1%
Get/sqlite-4                                14.95 ± 20%
Get/dqlite-4                                11.96 ±  0%
Lease/sqlite-4                             1.306m ± 62%
Lease/dqlite-4                             663.2µ ± 49%
List/sqlite-tiny/all-4                     192.0m ±  0%
List/sqlite-tiny/pagination-4               1.130 ±  3%
List/sqlite-fits-in-page/all-4             164.3m ±  0%
List/sqlite-fits-in-page/pagination-4      963.4m ±  3%
List/sqlite-overflows-page/all-4           185.9m ±  0%
List/sqlite-overflows-page/pagination-4     1.077 ±  0%
List/dqlite-tiny/all-4                     190.6m ±  0%
List/dqlite-tiny/pagination-4               1.125 ±  3%
List/dqlite-fits-in-page/all-4             163.1m ± 59%
List/dqlite-fits-in-page/pagination-4      954.6m ±  0%
List/dqlite-overflows-page/all-4           183.1m ±  0%
List/dqlite-overflows-page/pagination-4     1.072 ±  3%
Update/sqlite-4                             24.45 ±  3%
Update/dqlite-4                             23.97 ±  3%
geomean                                     1.189

                                        │     After      │
                                        │ page-writes/op │
Compaction/sqlite-4                        207.9m ± 1%
Compaction/dqlite-4                        187.7m ± 2%
Create/sqlite-4                             5.108 ± 0%
Create/dqlite-4                             4.133 ± 1%
Delete/sqlite-4                             5.316 ± 1%
Delete/dqlite-4                             4.389 ± 1%
Get/sqlite-4                                0.000 ± 0%
Get/dqlite-4                                0.000 ± 0%
Lease/sqlite-4                              0.000 ± 0%
Lease/dqlite-4                              0.000 ± 0%
List/sqlite-tiny/all-4                      0.000 ± 0%
List/sqlite-tiny/pagination-4               0.000 ± 0%
List/sqlite-fits-in-page/all-4              0.000 ± 0%
List/sqlite-fits-in-page/pagination-4       0.000 ± 0%
List/sqlite-overflows-page/all-4            0.000 ± 0%
List/sqlite-overflows-page/pagination-4     0.000 ± 0%
List/dqlite-tiny/all-4                      0.000 ± 0%
List/dqlite-tiny/pagination-4               0.000 ± 0%
List/dqlite-fits-in-page/all-4              0.000 ± 0%
List/dqlite-fits-in-page/pagination-4       0.000 ± 0%
List/dqlite-overflows-page/all-4            0.000 ± 0%
List/dqlite-overflows-page/pagination-4     0.000 ± 0%
Update/sqlite-4                             5.120 ± 1%
Update/dqlite-4                             4.160 ± 1%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                        │      After      │
                                        │ sec-reading/op  │
Compaction/sqlite-4                       109.7µ ±  19%
Compaction/dqlite-4                       34.40µ ±  11%
Create/sqlite-4                           36.90µ ± 503%
Create/dqlite-4                           8.200µ ± 111%
Delete/sqlite-4                           392.4µ ± 262%
Delete/dqlite-4                           39.90µ ±  38%
Get/sqlite-4                              82.60µ ±   4%
Get/dqlite-4                              23.10µ ±  20%
Lease/sqlite-4                             0.000 ±    ?
Lease/dqlite-4                             0.000 ±    ?
List/sqlite-tiny/all-4                    12.30µ ±   3%
List/sqlite-tiny/pagination-4             14.60µ ±   5%
List/sqlite-fits-in-page/all-4            17.20µ ±  34%
List/sqlite-fits-in-page/pagination-4     56.10µ ±   2%
List/sqlite-overflows-page/all-4          52.40µ ±  12%
List/sqlite-overflows-page/pagination-4   53.50µ ± 180%
List/dqlite-tiny/all-4                    3.200µ ±  22%
List/dqlite-tiny/pagination-4             5.400µ ±  17%
List/dqlite-fits-in-page/all-4            7.800µ ±  13%
List/dqlite-fits-in-page/pagination-4     18.70µ ±   9%
List/dqlite-overflows-page/all-4          29.10µ ±   2%
List/dqlite-overflows-page/pagination-4   38.00µ ±  14%
Update/sqlite-4                           176.8µ ±  59%
Update/dqlite-4                           104.8µ ±  11%
geomean                                                 ¹
¹ summaries must be >0 to compute geomean

                                        │     After      │
                                        │ sec-writing/op │
Compaction/sqlite-4                       9.500µ ±  9%
Compaction/dqlite-4                       7.800µ ± 10%
Create/sqlite-4                           1.219m ±  8%
Create/dqlite-4                           33.70µ ± 18%
Delete/sqlite-4                           1.442m ± 11%
Delete/dqlite-4                           21.80µ ± 46%
Get/sqlite-4                               0.000 ±  0%
Get/dqlite-4                               0.000 ±  0%
Lease/sqlite-4                             0.000 ±  0%
Lease/dqlite-4                             0.000 ±  0%
List/sqlite-tiny/all-4                     0.000 ±  0%
List/sqlite-tiny/pagination-4              0.000 ±  0%
List/sqlite-fits-in-page/all-4             0.000 ±  0%
List/sqlite-fits-in-page/pagination-4      0.000 ±  0%
List/sqlite-overflows-page/all-4           0.000 ±  0%
List/sqlite-overflows-page/pagination-4    0.000 ±  0%
List/dqlite-tiny/all-4                     0.000 ±  0%
List/dqlite-tiny/pagination-4              0.000 ±  0%
List/dqlite-fits-in-page/all-4             0.000 ±  0%
List/dqlite-fits-in-page/pagination-4      0.000 ±  0%
List/dqlite-overflows-page/all-4           0.000 ±  0%
List/dqlite-overflows-page/pagination-4    0.000 ±  0%
Update/sqlite-4                           1.343m ± 10%
Update/dqlite-4                           23.00µ ± 32%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                        │     After     │
                                        │     B/op      │
Compaction/sqlite-4                         413.0 ± 79%
Compaction/dqlite-4                       11.14Ki ± 18%
Create/sqlite-4                           21.23Ki ±  1%
Create/dqlite-4                           19.97Ki ±  0%
Delete/sqlite-4                           32.07Ki ±  6%
Delete/dqlite-4                           29.35Ki ±  0%
Get/sqlite-4                              25.05Ki ±  0%
Get/dqlite-4                              22.89Ki ±  0%
Lease/sqlite-4                            12.33Ki ±  0%
Lease/dqlite-4                            12.33Ki ±  0%
List/sqlite-tiny/all-4                    1.224Ki ±  2%
List/sqlite-tiny/pagination-4             1.520Ki ±  4%
List/sqlite-fits-in-page/all-4            4.933Ki ±  4%
List/sqlite-fits-in-page/pagination-4     9.096Ki ±  3%
List/sqlite-overflows-page/all-4          25.72Ki ±  3%
List/sqlite-overflows-page/pagination-4   33.79Ki ±  7%
List/dqlite-tiny/all-4                      836.0 ±  4%
List/dqlite-tiny/pagination-4               805.0 ±  2%
List/dqlite-fits-in-page/all-4            4.236Ki ±  4%
List/dqlite-fits-in-page/pagination-4     4.380Ki ±  4%
List/dqlite-overflows-page/all-4          21.13Ki ±  1%
List/dqlite-overflows-page/pagination-4   23.21Ki ±  5%
Update/sqlite-4                           30.22Ki ±  1%
Update/dqlite-4                           27.48Ki ±  0%
geomean                                   8.861Ki

                                        │    After    │
                                        │  allocs/op  │
Compaction/sqlite-4                       14.00 ± 93%
Compaction/dqlite-4                       268.0 ± 17%
Create/sqlite-4                           454.0 ±  2%
Create/dqlite-4                           371.0 ±  0%
Delete/sqlite-4                           712.0 ±  8%
Delete/dqlite-4                           510.0 ±  0%
Get/sqlite-4                              563.0 ±  0%
Get/dqlite-4                              407.0 ±  0%
Lease/sqlite-4                            224.0 ±  0%
Lease/dqlite-4                            224.0 ±  0%
List/sqlite-tiny/all-4                    40.00 ±  5%
List/sqlite-tiny/pagination-4             52.00 ±  6%
List/sqlite-fits-in-page/all-4            45.00 ±  4%
List/sqlite-fits-in-page/pagination-4     83.00 ±  2%
List/sqlite-overflows-page/all-4          55.00 ±  4%
List/sqlite-overflows-page/pagination-4   70.00 ±  6%
List/dqlite-tiny/all-4                    13.00 ±  8%
List/dqlite-tiny/pagination-4             12.00 ±  8%
List/dqlite-fits-in-page/all-4            17.00 ±  6%
List/dqlite-fits-in-page/pagination-4     18.00 ±  6%
List/dqlite-overflows-page/all-4          29.00 ±  3%
List/dqlite-overflows-page/pagination-4   33.00 ±  6%
Update/sqlite-4                           670.0 ±  1%
Update/dqlite-4                           491.0 ±  0%
geomean                                   100.7

                                        │         After         │
                                        │ network-bytes-read/op │
Compaction/dqlite-4                               4.126Ki ± 18%
Create/dqlite-4                                     239.4 ±  0%
Delete/dqlite-4                                   1.157Ki ±  0%
Get/dqlite-4                                      1.133Ki ±  0%
Lease/dqlite-4                                    0.02719 ± 44%
List/dqlite-tiny/all-4                              189.2 ±  5%
List/dqlite-tiny/pagination-4                       177.2 ±  2%
List/dqlite-fits-in-page/all-4                    1.203Ki ±  6%
List/dqlite-fits-in-page/pagination-4             1.228Ki ±  7%
List/dqlite-overflows-page/all-4                  6.190Ki ±  1%
List/dqlite-overflows-page/pagination-4           7.080Ki ±  8%
Update/dqlite-4                                     564.5 ±  0%
geomean                                             438.8

                                        │          After           │
                                        │ network-bytes-written/op │
Compaction/dqlite-4                                   5.459 ±  13%
Create/dqlite-4                                       112.5 ±   1%
Delete/dqlite-4                                       423.5 ±   0%
Get/dqlite-4                                          80.50 ±   0%
Lease/dqlite-4                                      0.01127 ± 432%
List/dqlite-tiny/all-4                              0.03727 ±  10%
List/dqlite-tiny/pagination-4                       0.03723 ±  10%
List/dqlite-fits-in-page/all-4                      0.05053 ±  10%
List/dqlite-fits-in-page/pagination-4               0.06967 ±  10%
List/dqlite-overflows-page/all-4                    0.06411 ±   2%
List/dqlite-overflows-page/pagination-4             0.09634 ±  19%
Update/dqlite-4                                       263.5 ±   0%
geomean                                               1.054

marco6
marco6 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@marco6 marco6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louiseschmidtgen louiseschmidtgen merged commit 2f7a13a into v1.2 Feb 12, 2025
6 checks passed
@louiseschmidtgen louiseschmidtgen deleted the v1.2-mem-leak-fix branch February 12, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco6 marco6 marco6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louiseschmidtgen @marco6