Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up fixes on k8s-dqlite build process #91

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Follow up fixes on k8s-dqlite build process #91

merged 1 commit into from
Feb 28, 2024

Conversation

neoaggelos
Copy link
Contributor

Summary

Follow up fixes on #90

Changes

  • use bin/dynamic/lib for dqlite shared libraries
  • configurable build-scripts directory
  • use go install for dqlite cli tool

@neoaggelos
followup fixes
9da5951 
- use bin/dynamic/lib for dqlite shared libraries
- configurable build-scripts directory
- use go install for dqlite cmd tool
@neoaggelos neoaggelos requested a review from a team as a code owner February 28, 2024 09:34
ktsakalozos
ktsakalozos approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@ktsakalozos ktsakalozos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@neoaggelos neoaggelos merged commit 4bf13af into master Feb 28, 2024
9 checks passed
@berkayoz berkayoz deleted the KU-401/followup branch September 2, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsakalozos ktsakalozos ktsakalozos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neoaggelos @ktsakalozos