generated from canonical/is-charms-template-repo
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subordinate charm config PoC #160
Draft
eaudetcobello
wants to merge
9
commits into
main
Choose a base branch
from
KU-2073/subordinate-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty... i provided you some places to improve. But yeah this is coming along
mateoflorido
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I have a few suggestions
eaudetcobello
force-pushed
the
KU-2073/subordinate-poc
branch
from
November 7, 2024 20:24
ed06780
to
8dc67cc
Compare
eaudetcobello
force-pushed
the
KU-2073/subordinate-poc
branch
from
November 7, 2024 20:36
597d80a
to
f65a944
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: Internal spec
Goes with: https://github.com/eaudetcobello/k8s-load-balancer-poc/blob/main/src/charm.py
Overview
Adds the
feature
interface for subordinate charms to attach to. Subordinate charms can change relation data to communicate with k8s-operator and configure cluster features.Rationale
The
feature
interface and observing the relation-changed event is needed to act when a subordinate charm is related to k8s-operator.Juju Events Changes
Observe feature-relation-changed events.
Module Changes
None.
Library Changes
None.
Checklist
src-docs
urgent
,trivial
,complex
)