Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subordinate charm config PoC #160

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello commented Nov 6, 2024

Applicable spec: Internal spec

Goes with: https://github.com/eaudetcobello/k8s-load-balancer-poc/blob/main/src/charm.py

Overview

Adds the feature interface for subordinate charms to attach to. Subordinate charms can change relation data to communicate with k8s-operator and configure cluster features.

Rationale

The feature interface and observing the relation-changed event is needed to act when a subordinate charm is related to k8s-operator.

Juju Events Changes

Observe feature-relation-changed events.

Module Changes

None.

Library Changes

None.

Checklist

@eaudetcobello eaudetcobello changed the title Ku 2073/subordinate poc Subordinate charm config PoC Nov 6, 2024
github-actions[bot]

This comment was marked as off-topic.

Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty... i provided you some places to improve. But yeah this is coming along

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved
charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved
charms/worker/k8s/src/charm.py Show resolved Hide resolved
redeploy.sh Outdated Show resolved Hide resolved
charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved
charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have a few suggestions

charms/worker/k8s/src/charm.py Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants