Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for service-cidr and control-plane-taints #43

Merged
merged 5 commits into from
Apr 20, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Mar 8, 2024

Introduces config service-cidr and register-with-taints. I considered also introducing cidr -- but may wait and leave it default for now in case we later introduce CNI relation

Pairs with snap changes

@addyess addyess requested a review from a team as a code owner March 8, 2024 22:10
@addyess addyess force-pushed the KU-326/bootstrap-with-taints branch 2 times, most recently from e45f1db to 63cee5e Compare March 22, 2024 13:40
@addyess addyess changed the title Bootstrap with bootstrapConfig Configuration for service-cidr and control-plane-taints Mar 22, 2024
Copy link
Contributor

@eaudetcobello eaudetcobello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Docstrings are clear as well.

@addyess addyess force-pushed the KU-326/bootstrap-with-taints branch from 0e5288b to 7c66835 Compare April 15, 2024 20:57
@addyess addyess force-pushed the KU-326/bootstrap-with-taints branch from c4cbf38 to 4ed0c68 Compare April 15, 2024 21:39
@addyess addyess merged commit 873c263 into main Apr 20, 2024
34 checks passed
@addyess addyess deleted the KU-326/bootstrap-with-taints branch April 20, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants