fix: ensure nf_conntrack module loaded for kube-proxy. #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Oct 16, 2024
| + # Note that the 'iptable_nat' module which is automatically loaded | ||
| + # by Cilium would load 'nf_conntrack' as a dependency anyway, | ||
| + # but we add a separate explicit entry for it for safety. | ||
| + conntrack-module-load: |
There was a problem hiding this comment.
This causes the build to fail:
yaml.parser.ParserError: while parsing a block mapping
in "/home/runner/work/k8s-snap/k8s-snap/snap/snapcraft.yaml", line 4[33](https://github.com/canonical/k8s-snap/actions/runs/11369169743/job/31625959021?pr=743#step:8:34), column 5
expected <block end>, but found '-'
in "/home/runner/work/k8s-snap/k8s-snap/snap/snapcraft.yaml", line 4[34](https://github.com/canonical/k8s-snap/actions/runs/11369169743/job/31625959021?pr=743#step:8:35), column 5
aznashwan
force-pushed
the
load_nf_conntrack
branch
from
a75d972
to
fc8b180
Compare
|
looks like this breaks the integration tests. |
Yep, currently working through the failure on 20.04 in strict mode and will get to the main clustering tests afterwards! |
aznashwan
force-pushed
the
load_nf_conntrack
branch
from
fc8b180
to
dc3e6d5
Compare
aznashwan
force-pushed
the
load_nf_conntrack
branch
2 times, most recently
from
3a46376
to
d68616a
Compare
This patch ensures that the `nf_conntrack` kernel module is loaded before the `kube-proxy` service is started so it can read some necessary conntrack module-related params from procfs. Previously, although the `kube-proxy` service always crashed if the module wasn't loaded, this wasn't that common of an occurrence in practice as there are quite a few ways `nf_conntrack` gets loaded transparently: * Cilium [automatically loads `iptable_nat`](https://github.com/cilium/cilium/blob/63cd391f93b4e2c865268241d384504348672042/pkg/datapath/iptables/iptables.go#L367-L368) after a small startup delay, whose dependency tree includes `nf_conntrack` * starting firewalld/ufw/most other firewall services * setting iptables/nftables rules which imply session tracking By explicitly loading `nf_conntrack` from the `kube-proxy` service wrapper directly, it should ensure the procfs values kube-proxy reads are always present on startup. Signed-off-by: Nashwan Azhari <nashwan.azhari@canonical.com>
Signed-off-by: Nashwan Azhari <nashwan.azhari@canonical.com>
aznashwan
force-pushed
the
load_nf_conntrack
branch
from
d68616a
to
c41f8c2
Compare
|
@bschimke95 the mixed-version cluster test seems to have behaved nicely this time, and the only Go failure is an unrelated spellcheck, so PTAL! |
|
Go unit test failure is unrelated and fixed here: #809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that the
nf_conntrackkernel module is loaded before thekube-proxyservice is started so it can read some necessary conntrack module-related params from procfs.Previously, although the
kube-proxyservice always crashed if the module wasn't loaded, this wasn't that common of an occurrence in practice as there are quite a few waysnf_conntrackgets loaded transparently:iptable_natafter a small startup delay, whose dependency tree includesnf_conntrackBy explicitly loading
nf_conntrackfrom thekube-proxyservice wrapper directly, it should ensure the procfs values kube-proxy reads are always present on startup.