Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for cis hardening #802

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ktsakalozos
Copy link
Member

  • update the CIS hardening how-to with CIS auditing section
  • update the CIS reports generation tool to give us the format we want
  • update the CIS hardening checks to include dqlite in place of etcd
  • review the CIS hardening checks

@ktsakalozos ktsakalozos requested a review from a team as a code owner November 15, 2024 12:03
Copy link
Contributor

Hi, looks like pyspelling job found some issues, you can check it here

@@ -15,77 +22,31 @@ This guide assumes the following:
[getting-started-guide] guide)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplication of link


```
sudo -E kube-bench --version ck8s-dqlite-cis-1.24 --config-dir ./kube-bench-ck8s-cfg/cfg/ --config ./kube-bench-ck8s-cfg/cfg/config.yaml
sudo -E kube-bench --version ck8s-cis-1.24 --config-dir ./kube-bench-ck8s-cfg/cfg/ --config ./kube-bench-ck8s-cfg/cfg/config.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with local setup and runs fine


##### Control 1.1.1

###### Description:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding description, remediation, audit and expected output as h6 headers clutter the side navigation. Leaving Control x.x.x as h5 and then making the rest bold with text will make it tidier while still remaining the same visually.

k8s/scripts/cis/README.md Show resolved Hide resolved
k8s/scripts/cis/README.md Show resolved Hide resolved
k8s/scripts/cis/cis-template.jinja2 Show resolved Hide resolved
k8s/scripts/cis/cis-yaml-to-md.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants