Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integrate 2.2.0 rocks #520

Merged
merged 9 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charms/kfp-api/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ resources:
oci-image:
type: oci-image
description: Backing OCI image
upstream-source: gcr.io/ml-pipeline/api-server:2.2.0
upstream-source: charmedkubeflow/api-server:2.2.0-4d2f32c
requires:
mysql:
interface: mysql
Expand Down
1 change: 1 addition & 0 deletions charms/kfp-api/src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def __init__(self, *args):
f"--config={CONFIG_DIR} "
f"--sampleconfig={SAMPLE_CONFIG} "
"-logtostderr=true "
f"--logLevel={self.model.config['log-level']}"
)
self._container_name = "apiserver"
self._database_name = "mlpipeline"
Expand Down
1 change: 1 addition & 0 deletions charms/kfp-api/tests/unit/test_operator.py
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ def test_install_with_all_inputs_and_pebble(
"--config=/config "
"--sampleconfig=/config/sample_config.json "
"-logtostderr=true "
f"--logLevel={harness.charm.config['log-level']}"
)
assert pebble_exec_command == f"bash -c '{exec_command}'"

Expand Down
2 changes: 1 addition & 1 deletion charms/kfp-metadata-writer/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resources:
oci-image:
type: oci-image
description: OCI image for KFP Metadata Writer
upstream-source: gcr.io/ml-pipeline/metadata-writer:2.2.0
upstream-source: charmedkubeflow/metadata-writer:2.2.0-cff3205
requires:
grpc:
interface: k8s-service
Expand Down
2 changes: 1 addition & 1 deletion charms/kfp-persistence/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ resources:
oci-image:
type: oci-image
description: Backing OCI image
upstream-source: gcr.io/ml-pipeline/persistenceagent:2.2.0
upstream-source: charmedkubeflow/persistenceagent:2.2.0-8af6d3c
requires:
kfp-api:
interface: k8s-service
Expand Down
1 change: 1 addition & 0 deletions charms/kfp-persistence/src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ def __init__(self, *args, **kwargs):
"NAMESPACE": "",
"TTL_SECONDS_AFTER_WORKFLOW_FINISH": "86400",
"NUM_WORKERS": "2",
"EXECUTIONTYPE": "Workflow",
DnPlas marked this conversation as resolved.
Show resolved Hide resolved
},
# provide function to pebble with which it can get service configuration from
# relation
Expand Down
12 changes: 7 additions & 5 deletions charms/kfp-persistence/src/components/pebble_components.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,13 @@ def get_layer(self) -> Layer:
# setup command with parameters provided in configuration
command = (
"persistence_agent",
"--logtostderr=true",
"--namespace=",
"--ttlSecondsAfterWorkflowFinish=86400",
"--numWorker=2",
f"--mlPipelineAPIServerName={service_config.KFP_API_SERVICE_NAME}",
" --logtostderr=true",
" --namespace=",
f" --ttlSecondsAfterWorkflowFinish={self._environment['TTL_SECONDS_AFTER_WORKFLOW_FINISH']}", # noqa: 501
f" --numWorker={self._environment['NUM_WORKERS']}",
f" --mlPipelineAPIServerName={service_config.KFP_API_SERVICE_NAME}",
f" --executionType {self._environment['EXECUTIONTYPE']}",
f" --logLevel={self._environment['LOG_LEVEL']}",
)

# generate and return layer
Expand Down
2 changes: 1 addition & 1 deletion charms/kfp-schedwf/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ resources:
oci-image:
type: oci-image
description: Backing OCI image
upstream-source: gcr.io/ml-pipeline/scheduledworkflow:2.2.0
upstream-source: charmedkubeflow/scheduledworkflow:2.2.0-517f00c
requires:
logging:
interface: loki_push_api
Expand Down
2 changes: 1 addition & 1 deletion charms/kfp-schedwf/src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def __init__(self, *args):
service_name="controller",
timezone=self.model.config["timezone"],
log_level=self.model.config["log-level"],
namespace=self.model.name,
namespace="",
),
depends_on=[self.kubernetes_resources],
)
Expand Down
6 changes: 4 additions & 2 deletions charms/kfp-schedwf/src/components/pebble_component.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def __init__(
"LOG_LEVEL": log_level,
}
self.namespace = namespace
self.log_level = log_level

def get_layer(self) -> Layer:
"""Defines and returns Pebble layer configuration
Expand All @@ -45,8 +46,9 @@ def get_layer(self) -> Layer:
"override": "replace",
"summary": "scheduled workflow controller service",
"startup": "enabled",
"command": "/bin/controller --logtostderr=true"
" --namespace={self.namespace}",
"command": f"/bin/controller --logtostderr=true"
f" --namespace={self.namespace}"
DnPlas marked this conversation as resolved.
Show resolved Hide resolved
f" --logLevel={self.log_level}",
DnPlas marked this conversation as resolved.
Show resolved Hide resolved
"environment": self.environment,
}
},
Expand Down
2 changes: 1 addition & 1 deletion charms/kfp-viewer/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ resources:
kfp-viewer-image:
type: oci-image
description: OCI image for KFP Viewer
upstream-source: gcr.io/ml-pipeline/viewer-crd-controller:2.2.0
upstream-source: charmedkubeflow/viewer-crd-controller:2.2.0-aaa1d41
requires:
logging:
interface: loki_push_api
Expand Down
2 changes: 1 addition & 1 deletion charms/kfp-viz/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ resources:
oci-image:
type: oci-image
description: OCI image for ml-pipeline-visualizationserver
upstream-source: gcr.io/ml-pipeline/visualization-server:2.2.0
upstream-source: charmedkubeflow/visualization-server:2.2.0-d65cd0c
provides:
kfp-viz:
interface: k8s-service
Expand Down
Loading