Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ST124 and Use python plugin instead of charm plugin in charmcraft.yaml files #271

Closed
NohaIhab opened this issue Jan 15, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@NohaIhab
Copy link
Contributor

Context

These changes are necessary to push forward with using data platform workflows latest version, that is using the latest charmcraft.
Data platform workflows will only support ST124 "shorthand notation" syntax , see https://github.com/canonical/data-platform-workflows/blob/main/.github/workflows/build_charm.md#required-charmcraftyaml-syntax.
Using platforms or base instead of bases with charmcraft 3 will result in different behavior if you're currently using the default charm plugin, see canonical/charmcraft#2055.

What needs to get done

Refactor all charmcraft.yaml files in this repo to:

  1. Use ST124 notation
  2. Use python plugin instead of charm plugin

Definition of Done

all charms in this repo use ST124 notation and python plugin

@NohaIhab NohaIhab added the enhancement New feature or request label Jan 15, 2025
Copy link

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6737.

This message was autogenerated

orfeas-k added a commit that referenced this issue Jan 29, 2025
Refactor charmcraft.yaml files to enable the usage of charmcraft-cache
and data-platform-workflows in general.

Close #271
orfeas-k added a commit that referenced this issue Jan 30, 2025
Refactor charmcraft.yaml files to enable the usage of charmcraft-cache
and data-platform-workflows in general.

Close #271
orfeas-k added a commit that referenced this issue Feb 3, 2025
* build: refactor charmcraft.yaml to use ST124 notation (#282)

Refactor charmcraft.yaml files to enable the usage of charmcraft-cache
and data-platform-workflows in general.

Close #271

* refactor(ci): use data-platform-workflows in on_pull/push workflows (#284)

* refactor(ci): use data-platform-workflows in on_pull/push workflows

* Enable the usage of `build_charm.yaml` workflow, which allows
  independent and cached charm builds, making the CI more efficient and
  fast.
* Refactor the tests and the integrate workflow to be able to use the
  charm artefacts generated by the `build_charm.yaml` workflow:
  - Refactor integrate.yaml to be ci.yaml, a workflow that now takes
    care for the whole pipeline from generating charm paths, to
    building, to testing, and then releasing. This change will replace
    on_pull_request.yaml.
  - on_push.yaml is now replaced entirely by release, which will run on
    pushes to main or track/* branches. This workflow is in charge of
    building -> testing -> releasing.
  - Refactor individual and repository level integration tests to be
    able to use charm artefacts besides building them.

Close #272

* refactor(ci): Replace release.yaml with promote.yaml (#285)

* Add promote.yaml workflow to replace the old release.yaml
  workflow_dispatch funcionality.
* Remove publish.yaml workflow as the release process is handled by the
  recently refactor release.yaml.

Fix #277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants