Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI incorrectly tries to publish kserve-web-app in track/0.10 #156

Open
i-chvets opened this issue Aug 24, 2023 · 2 comments
Open

CI incorrectly tries to publish kserve-web-app in track/0.10 #156

i-chvets opened this issue Aug 24, 2023 · 2 comments

Comments

@i-chvets
Copy link
Contributor

Bug Description

kserve-web-app is not available in 1.7 relase (i.e. track/0..10)
CI is trying to publish this charm and fails.

To Reproduce

Create a debug PR and observe failure in Publish workflow https://github.com/canonical/kserve-operators/blob/main/.github/workflows/publish.yaml
Example of failing PR: #155

Environment

Publish action in this repository https://github.com/canonical/kserve-operators/blob/main/.github/workflows/publish.yaml

Relevant Log Output

/snap/bin/charmcraft upload-resource --quiet kserve-web-app kserve-web-app-image --image a84dea08430b
Store operation failed:
- resource-not-found: No oci-image type "kserve-web-app-image" resource found
Full execution log: '/home/runner/.local/state/charmcraft/log/charmcraft-20230824-153552.895475.log'
Error: The process '/snap/bin/charmcraft' failed with exit code 1
Error: Error: The process '/snap/bin/charmcraft' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/canonical/charming-actions/2.3.0/dist/upload-charm/index.js:3763:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/canonical/charming-actions/2.3.0/dist/upload-charm/index.js:3746:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/canonical/charming-actions/2.3.0/dist/upload-charm/index.js:3640:27)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1100:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)
/usr/bin/sudo test -d /root/snap/charmcraft/common/cache/charmcraft/log
No charmcraft logs generated, skipping artifact upload.

Additional Context

There were fixes merged into main branch that addressed this problem:
#141

In particular this change needs to be cherry picked into track/0.10 branch:
1263f31
i-chvets pushed a commit that referenced this issue Aug 24, 2023
fix: ported fix for failing charm publish
a75bb10 
#156

Summary of changes:
- Updated workflow not to include kserve-web-app charm in list of charms
  for publishing.
@i-chvets i-chvets mentioned this issue Aug 24, 2023
Merged
i-chvets added a commit that referenced this issue Aug 25, 2023
@i-chvets
Kf 4223 fix do not publish kserve web app charm (#157)
b6135b1 
* fix: ported fix for failing charm publish
#156

Summary of changes:
- Updated workflow not to include kserve-web-app charm in list of charms
  for publishing.
@i-chvets i-chvets mentioned this issue Aug 25, 2023
Closed
@kimwnasptd
Copy link
Contributor

@i-chvets should this still be open?

@i-chvets
Copy link
Contributor Author

i-chvets commented Aug 28, 2023 •
edited
Loading

@kimwnasptd Incorrect publishing is fixed in PR #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimwnasptd @i-chvets