build: refactor charmcraft.yaml to use st124 notation #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to use the data-platform-workflows, specially to be compatible with charmcraft cache, the charmcraft.yaml files of all charms in this repository need to follow st124 notation. Fixes #154
NohaIhab
reviewed
Jan 23, 2025
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
DnPlas
merged commit 4abe7fe
into
KF-6217-use-cache-builds-dev-branch
18 of 20 checks passed
DnPlas
added a commit
that referenced
this pull request
Jan 30, 2025
* build: refactor charmcraft.yaml to use st124 notation (#158) * build: refactor charmcraft.yaml to use st124 notation In order to be able to use the data-platform-workflows, specially to be compatible with charmcraft cache, the charmcraft.yaml files of all charms in this repository need to follow st124 notation. Fixes #154 * ci, refactor: use data-platform-workflows in on_pull/push workflows (#159) * ci, refactor: use data-platform-workflows in on_pull/push workflows This commit enables the usage of build_charm.yaml workflow, which allows independent and cached charm builds, making the CI more efficient and fast. This commit also refactors the tests and the integrate workflow to be able to use the charm artefacts generated by the build_charm.yaml workflow. In summary this change: 1. Uses build_charm.yaml in on_{pull&push}.yaml to enable individual cached builds 2. Refactors individual and repository level integration tests to be able to use charm artefacts besides building them 3. Modifies integrate.yaml to download the charm artefacts and uses them in the tox integrate command Fixes #155 * ci: replaces publish.yaml workflow with promote.yaml workflow (#161) * ci: replaces publish.yaml workflow with promote.yaml workflow The promote.yaml workflow replaces the old release workflow dispatch (previously known as release.yaml). This commit removes the publish.yaml workflow as the release process is all handled by a recently refactored release.yaml, and promoting charms is done in a simple workflow dispatch coming from promote.yaml. Fixes #157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to use the data-platform-workflows, specially to be compatible with charmcraft cache, the charmcraft.yaml files of all charms in this repository need to follow st124 notation.
Fixes #154
Please NOTE this PR targets a dev branch as there is still pending work:
Manual testing