Skip to content

Commit

Permalink
Fix deploy error due to new pip / old setuptools conflict
Browse files Browse the repository at this point in the history
Newer versions of pip (>=19.0) don't work with older versions of
setuptools (<40) due to an attribute error.  If
`include_system_packages` is `false` (now the default), this is not an
issue because of the newer setuptools that gets installed into the venv.
However, when it's `true`, which is required for some charms, the
install fails because pip somehow prefers the older system-installed
setuptools over the newer one in the venv. Pinning pip avoids the
problem until we can find a better solution.

See:
  * https://discourse.jujucharms.com/t/wheel-building-fails-during-charm-deployment/1947
  * pypa/pip#6164
  • Loading branch information
johnsca committed Aug 19, 2019
1 parent 7cb1b66 commit 20c5571
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion wheelhouse.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pip>=18.1,<19.2
pip>=18.1,<19.0
setuptools<42
setuptools-scm<=1.17.0
charmhelpers>=0.4.0,<1.0.0
Expand Down

0 comments on commit 20c5571

Please sign in to comment.