Fix deploy error due to new pip / old setuptools conflict #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of pip (>=19.0) don't work with older versions of setuptools (<40) due to an attribute error. If `include_system_packages` is `false` (now the default), this is not an issue because of the newer setuptools that gets installed into the venv. However, when it's `true`, which is required for some charms, the install fails because pip somehow prefers the older system-installed setuptools over the newer one in the venv. Pinning pip avoids the problem until we can find a better solution. See: * https://discourse.jujucharms.com/t/wheel-building-fails-during-charm-deployment/1947 * pypa/pip#6164
|
Tested with both trusty and bionic with |
kwmonroe
approved these changes
Aug 19, 2019
There was a problem hiding this comment.
LGTM as a stop-gap, but oof:
fails because pip somehow prefers the older system-installed setuptools over the newer one in the venv
This feels like an easy fix to accidentally clobber because future maintainers forget these roots. I'm fine enough with this being a pip 19.(0+n) issue, but let's pour one out for our future selves just in case.
kwmonroe
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of pip (>=19.0) don't work with older versions of setuptools (<40) due to an attribute error. If
include_system_packagesisfalse(now the default), this is not an issue because of the newer setuptools that gets installed into the venv. However, when it'strue, which is required for some charms, the install fails because pip somehow prefers the older system-installed setuptools over the newer one in the venv. Pinning pip avoids the problem until we can find a better solution.See: