Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu Jammy support. #96

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Ubuntu Jammy support. #96

merged 2 commits into from
Aug 19, 2022

Conversation

mkalcok
Copy link
Contributor

@mkalcok mkalcok commented Aug 17, 2022

Dependency: This change to layer:beats-base has to be merge as well for proper Ubuntu 22.04 support (more info in the PR).

This change adds support for deployment of filebeats charm on Ubuntu 22.04 and adds charmcraft.yaml file for build compatibility with charmcraft.

Two main changes were needed:

  • Drop dependency on charms.templating.jinja2 which depends on Tempita package that does not work on python3.10 (More info in PR linked above)
  • Add clone3 syscall to list of allowed syscalls. Absence of this syscall caused an issues that are described in this Github Issue (It's from apm project, not filebeats but the problem and the solution are the same)

Resolves #94

Copy link
Contributor

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pjack
Copy link
Contributor

Pjack commented Aug 18, 2022

  1. Please also check if there is any useful code in this PR provided by Alvaro before. I will drop his PR after merge this one.
  2. How to link this issue to this PR?

@mkalcok
Copy link
Contributor Author

mkalcok commented Aug 18, 2022

I linked #94 issue and added Alvaro's changes to the README.md

Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've made a suggestion in the inline comment.

syscalls:
- action: allow
names:
- clone3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we already supports filebeat 7, could you please check if this syscall is also needed for filebeat-7.yaml? You can test it by replacing the default value of install_sources config option with "deb https://artifacts.elastic.co/packages/7.x/apt stable main"

Copy link
Contributor Author

@mkalcok mkalcok Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to mention this in the description but I forgot. Filebeat 7 has this problem fixed in 7.15.2 so I don't think we need to explicitly configure it.

@kwmonroe
Copy link
Contributor

This LGTM, but i'm curious if you need jammy listed in the metadata.yaml:

https://github.com/juju-solutions/layer-filebeat/blob/master/metadata.yaml

I presume that charmcraft and the pack/push procedure means you don't, but wanted to double check just in case it was an oversight.

@agileshaw
Copy link
Contributor

@kwmonroe Thanks for the review. The series in metadata.yaml is deprecated if using charmcraft. The best practice would be to replace the line with series: []. But since we are planning to refactoring the charm in near future, I think we can leave it as is right now and save the change in a new PR.

@kwmonroe kwmonroe merged commit 564f6e5 into canonical:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No jammy (22.04 LTS) support
4 participants