Only insert labels that do not already exist #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Alert labels are being overwritten, when they already exist.
This is a problem for deployments with grafana-agent, such as:
Before this change, the alert labels of
some-charm
would be set to grafana-agent's topology.Solution
Only insert labels that do not already exist. This is exactly what we're doing in cos-lib.
(In a different PR, we should refactor loki_push_api to use cos-lib.)
Addresses canonical/grafana-agent-k8s-operator#275.
Context
This PR is in tandem with:
Testing Instructions
Deploy this bundle:
and make sure
expr
labels and alert labels are correct:Upgrade Notes
This change has no impact on Loki itself, but on related charms, so
charmcraft fetch-lib
etc.