Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement grafana_datasource_exchange #476

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Implement grafana_datasource_exchange #476

merged 5 commits into from
Dec 13, 2024

Conversation

michaeldmitry
Copy link
Contributor

@michaeldmitry michaeldmitry commented Dec 10, 2024 •
edited
Loading

Issue

Add a send-datasource endpoint to exchange datasource UIDs with other COS components.

Context

TODO:

Testing Instructions

  1. Deploy Tempo HA
  2. Deploy grafana-k8s
  3. Deploy loki-k8s from this branch
  4. Integrate tempo and grafana over grafana_datasource
  5. Integrate loki and grafana over grafana_datasource
  6. Integrate loki and tempo over grafana_datasource_exchange
  7. jhack show-relation loki tempo and observe the datasource UID of loki shared to tempo

@michaeldmitry michaeldmitry requested a review from a team as a code owner December 10, 2024 14:26
PietroPasotti
PietroPasotti reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some attention points for the implementation, still need to test the feature.

tests/scenario/conftest.py Outdated Show resolved Hide resolved
tests/integration/helpers.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
@PietroPasotti
Copy link
Contributor

image
all datasources appear healthy

@PietroPasotti PietroPasotti self-requested a review December 13, 2024 11:29
PietroPasotti
PietroPasotti approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job

@michaeldmitry michaeldmitry merged commit 54f7b1d into main Dec 13, 2024
13 checks passed
@michaeldmitry michaeldmitry deleted the TAP-8 branch December 13, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroPasotti PietroPasotti PietroPasotti approved these changes

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeldmitry @PietroPasotti