Skip to content

Commit

Permalink
fix(instance) show help text for instance root disk device on edit (#973
Browse files Browse the repository at this point in the history
)
  • Loading branch information
edlerd authored Oct 29, 2024
2 parents ec9c3bf + 720233f commit dd65f88
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
3 changes: 0 additions & 3 deletions src/pages/storage/StoragePoolSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@ interface Props {
setValue: (value: string) => void;
selectProps?: SelectProps;
hidePoolsWithUnsupportedDrivers?: boolean;
help?: string;
}

const StoragePoolSelector: FC<Props> = ({
value,
setValue,
selectProps,
hidePoolsWithUnsupportedDrivers = false,
help,
}) => {
const notify = useNotify();
const { data: settings } = useSettings();
Expand Down Expand Up @@ -82,7 +80,6 @@ const StoragePoolSelector: FC<Props> = ({
onChange={(e) => setValue(e.target.value)}
value={value}
{...selectProps}
help={help}
/>
);
};
Expand Down
8 changes: 3 additions & 5 deletions src/pages/storage/forms/StorageVolumeFormMain.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,10 @@ const StorageVolumeFormMain: FC<Props> = ({ formik, poolError }) => {
selectProps={{
disabled: !formik.values.isCreating,
error: poolError,
}}
help={
formik.values.isCreating
help: formik.values.isCreating
? undefined
: "Use the migrate button in the header to move the volume to a different storage pool."
}
: "Use the migrate button in the header to move the volume to a different storage pool.",
}}
/>
<Input
{...getFormProps(formik, "name")}
Expand Down

0 comments on commit dd65f88

Please sign in to comment.