Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to use a unique key in all table rows #1069

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jan 22, 2025

Done

  • ensure to use a unique key in all table rows to fix updates on search and filter of table contents

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • browse the tables and use search, ensure no errors are in the dev console from duplicate or missing keys.

…es on search and filter of table contents

Signed-off-by: David Edler <david.edler@canonical.com>
@webteam-app
Copy link

Copy link
Collaborator

@mas-who mas-who left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I see MainTable is using row index as keys if key is not provided. Btw I could not recreate the error on this branch or the main branch.

@edlerd
Copy link
Collaborator Author

edlerd commented Jan 23, 2025

Btw I could not recreate the error on this branch or the main branch.

I suspect a full re-render of the whole table to hide the underlying problem. We discovered this problem in the Anbox Cloud Dashboard within playwright tests.

@edlerd edlerd merged commit 8fbc8fc into canonical:main Jan 23, 2025
11 checks passed
@edlerd edlerd deleted the ensure-key-in-lists branch January 23, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants