-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to grafana from instance detail pages, add grafana provision script #943
Conversation
0173ac8
to
943bb78
Compare
c6580dd
to
ea26e7f
Compare
4a6143d
to
59cb7b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA looks good 👍 just got a few comments regarding the script
…ase url is configured, add the base url to the settings Signed-off-by: David Edler <david.edler@canonical.com>
Signed-off-by: David Edler <david.edler@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just one question about dep version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Done
QA