client: Create events listeners before making the op request

To ensure we have begun listening for events before the operation has
completed, we should explicitly create the events listener for the
operation before actually initiating the request that creates and starts
the operation.

Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>

client/lxd_containers.go

@@ -118,6 +118,13 @@ func (r *ProtocolLXD) CreateContainerFromBackup(args ContainerBackupArgs) (Opera
  req.Header.Set("Content-Type", "application/octet-stream")
  req.Header.Set("X-LXD-pool", args.PoolName)
 
+ // Set up the events listener before making the request so that
+ // the operation doesn't complete and emit the event before we've begun listening.
+ listener, err := r.getEvents(false)
+ if err != nil {
+ return nil, err
+ }
+
  // Send the request
  resp, err := r.DoHTTP(req)
  if err != nil {
@@ -141,6 +148,7 @@ func (r *ProtocolLXD) CreateContainerFromBackup(args ContainerBackupArgs) (Opera
  // Setup an Operation wrapper
  op := operation{
  Operation: *respOperation,
+ listener: listener,
  r: r,
  chActive: make(chan bool),
  }

client/lxd_images.go

@@ -495,6 +495,13 @@ func (r *ProtocolLXD) CreateImage(image api.ImagesPost, args *ImageCreateArgs) (
  return nil, err
  }
 
+ // Set up the events listener before making the request so that
+ // the operation doesn't complete and emit the event before we've begun listening.
+ listener, err := r.getEvents(false)
+ if err != nil {
+ return nil, err
+ }
+
  req, err := http.NewRequest("POST", reqURL, body)
  if err != nil {
  return nil, err
@@ -567,6 +574,7 @@ func (r *ProtocolLXD) CreateImage(image api.ImagesPost, args *ImageCreateArgs) (
  op := operation{
  Operation: *respOperation,
  r: r,
+ listener: listener,
  chActive: make(chan bool),
  }
 

client/lxd_instances.go

@@ -590,6 +590,13 @@ func (r *ProtocolLXD) CreateInstanceFromBackup(args InstanceBackupArgs) (Operati
  req.Header.Set("X-LXD-name", args.Name)
  }
 
+ // Set up the events listener before making the request so that
+ // the operation doesn't complete and emit the event before we've begun listening.
+ listener, err := r.getEvents(false)
+ if err != nil {
+ return nil, err
+ }
+
  // Send the request
  resp, err := r.DoHTTP(req)
  if err != nil {
@@ -614,6 +621,7 @@ func (r *ProtocolLXD) CreateInstanceFromBackup(args InstanceBackupArgs) (Operati
  op := operation{
  Operation: *respOperation,
  r: r,
+ listener: listener,
  chActive: make(chan bool),
  }
 

client/lxd_storage_volumes.go

@@ -1034,6 +1034,13 @@ func (r *ProtocolLXD) CreateStoragePoolVolumeFromISO(pool string, args StoragePo
  req.Header.Set("X-LXD-name", args.Name)
  req.Header.Set("X-LXD-type", "iso")
 
+ // Set up the events listener before making the request so that
+ // the operation doesn't complete and emit the event before we've begun listening.
+ listener, err := r.getEvents(false)
+ if err != nil {
+ return nil, err
+ }
+
  // Send the request.
  resp, err := r.DoHTTP(req)
  if err != nil {
@@ -1057,6 +1064,7 @@ func (r *ProtocolLXD) CreateStoragePoolVolumeFromISO(pool string, args StoragePo
  // Setup an Operation wrapper.
  op := operation{
  Operation: *respOperation,
+ listener: listener,
  r: r,
  chActive: make(chan bool),
  }
@@ -1097,6 +1105,13 @@ func (r *ProtocolLXD) CreateStoragePoolVolumeFromBackup(pool string, args Storag
  req.Header.Set("X-LXD-name", args.Name)
  }
 
+ // Set up the events listener before making the request so that
+ // the operation doesn't complete and emit the event before we've begun listening.
+ listener, err := r.getEvents(false)
+ if err != nil {
+ return nil, err
+ }
+
  // Send the request.
  resp, err := r.DoHTTP(req)
  if err != nil {
@@ -1120,6 +1135,7 @@ func (r *ProtocolLXD) CreateStoragePoolVolumeFromBackup(pool string, args Storag
  // Setup an Operation wrapper.
  op := operation{
  Operation: *respOperation,
+ listener: listener,
  r: r,
  chActive: make(chan bool),
  }