Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/suites/tls_restrictions: don't check for broken pipe error #14128

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

simondeziel
Copy link
Member

Making a TLS 1.2 connection with an unsupported cipher does not reliably produces a broken pipe error:

for _ in $(seq 100); do
    for cipher in ECDHE-ECDSA-AES128-SHA ECDHE-ECDSA-AES256-SHA; do
        my_curl --tls-max 1.2 --ciphers "${cipher}" -X GET "https://${LXD_ADDR}" -w "%{errormsg}\n"
    done
done 2>&1 | sort | uniq -c
      1 Empty reply from server
    196 OpenSSL SSL_write: Broken pipe, errno 32
      3 OpenSSL SSL_write: Connection reset by peer, errno 104

but it always fail so let not look for a specific error, just make sure the connection fails.

Making a TLS 1.2 connection with an unsupported cipher does not reliably
produces a broken pipe error:

```
for _ in $(seq 100); do
    for cipher in ECDHE-ECDSA-AES128-SHA ECDHE-ECDSA-AES256-SHA; do
        my_curl --tls-max 1.2 --ciphers "${cipher}" -X GET "https://${LXD_ADDR}" -w "%{errormsg}\n"
    done
done 2>&1 | sort | uniq -c
      1 Empty reply from server
    196 OpenSSL SSL_write: Broken pipe, errno 32
      3 OpenSSL SSL_write: Connection reset by peer, errno 104
```

but it always fail so let not look for a specific error, just make sure the
connection fails.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel marked this pull request as ready for review September 18, 2024 16:48
@tomponline tomponline merged commit 9fc1a6e into canonical:main Sep 18, 2024
30 checks passed
@simondeziel simondeziel deleted the tls-broken-pipe branch September 18, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants