Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API types for configuration metadata #14132

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

markylaing
Copy link
Contributor

This is so that we can manage configuration metadata with API extensions as we do with any other API response over /1.0

  • Adds an API extension for adding entity metadata to GET /1.0/configuration/metadata.
  • Adds types under shared/api for configuration metadata.
  • Updates entity metadata such that each entity maps to a JSON object, with requires_project and entitlements fields.
  • Enforces that generated metadata conforms to the new API type.
  • Updates the swagger doc for GET /1.0/configuration/metadata to include the newly defined type.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
They may be something like "true", but this is still a string.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
This includes adding the `requires_project` field, which will be required
for validating `lxc auth permission add/remove` command arguments.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
…finition.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing markylaing self-assigned this Sep 19, 2024
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Sep 19, 2024
Copy link

Heads up @mionaalex - the "Documentation" label was applied to this issue.

Copy link
Contributor

@kadinsayani kadinsayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants