lxd: Log error on resultErrListAppend
#14514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MggMuggins
requested changes
Nov 25, 2024
hamistao
force-pushed
the
log_instance_get_error
branch
from
a0650b2 to
25cfc02
Compare
yeah probably. |
tomponline
reviewed
Nov 26, 2024
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
hamistao
force-pushed
the
log_instance_get_error
branch
from
25cfc02 to
cff0be3
Compare
tomponline
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this
errparameter was unused. So I had this idea of, instead of removing it, logging these erros, as the errors used with that function are currently not being disclosed to the user in any way. This way it is clear why one was not able to get info on that particular instance when looking in the logs. If this logging is not desirable, I will update the PR to just remove the unused parameter.