Devices: CPU pinning fix (allow explicit pinning on isolated CPUs for VM instances) #14817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
mihalicyn
force-pushed
the
cpu_pinning_fix
branch
from
a41c95b to
8ab389b
Compare
gabrielmougard
previously approved these changes
Jan 20, 2025
mihalicyn
force-pushed
the
cpu_pinning_fix
branch
from
8ab389b to
ceb228b
Compare
tomponline
reviewed
Jan 20, 2025
tomponline
reviewed
Jan 20, 2025
mihalicyn
force-pushed
the
cpu_pinning_fix
branch
from
ceb228b to
563d066
Compare
tomponline
reviewed
Jan 21, 2025
tomponline
reviewed
Jan 21, 2025
tomponline
changed the title
…d CPUs Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
mihalicyn
force-pushed
the
cpu_pinning_fix
branch
from
563d066 to
daa8e1a
Compare
tomponline
reviewed
Jan 22, 2025
| @@ -431,6 +431,22 @@ func getNumaNodeToCPUMap() (numaNodeToCPU map[int64][]int64, err error) { | |||
| return numaNodeToCPU, err | |||
| } | |||
|
|
|||
| func getNumaCPUs(numaNodeToCPU map[int64][]int64, cpuNodes string) ([]int64, error) { | |||
There was a problem hiding this comment.
missing doc block on this function.
As it would be useful to the caller and reviewer to understand what is in the returned values and what format the cpuNodes string is in.
tomponline
reviewed
Jan 22, 2025
tomponline
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14709