feat: allow multiple DynamicTable per page MAASENG-3091 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
petermakowski
force-pushed
the
feat-allow-multiple-DynamicTable-components-per-page-MAASENG-3091
branch
from
cb90c75
to
d8b4bda
Compare
petermakowski
force-pushed
the
feat-allow-multiple-DynamicTable-components-per-page-MAASENG-3091
branch
2 times, most recently
from
49095cf
to
e0c4462
Compare
petermakowski
force-pushed
the
feat-allow-multiple-DynamicTable-components-per-page-MAASENG-3091
branch
from
e0c4462
to
41d5d88
Compare
petermakowski
force-pushed
the
feat-allow-multiple-DynamicTable-components-per-page-MAASENG-3091
branch
from
41d5d88
to
2d41e0b
Compare
ndv99
approved these changes
Apr 24, 2024
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
variantpropNote: Variant prop is required deliberately so that we're careful when updating existing implementations and carefully chose which variant should be used.
Why Context API?
Context API provides a way to pass data through the component tree without having to pass props down manually at every level. This also allows to use this prop in all child components and make sure it's consistent and cannot be overwritten.
QA steps
Fixes
Fixes: https://warthogs.atlassian.net/browse/MAASENG-3091 #128
Screenshots
After
Notes