-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LimitedInput component WIP #134
base: main
Are you sure you want to change the base?
Conversation
content: var(--immutable, ""); | ||
top: var(--top, "inherit"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware that this isn't a perfect solution, but for now it's workable as advised by @petermakowski. I'll create a jira ticket to investigate this implementation and find something better, but for now this should unblock canonical/maas-ui#5420
I've discovered a bug when using this in |
I've fixed this now, which also fixed the immutable text not showing in the component docs. |
There's some visual issues that only occur when viewing this component in storybook that can't be replicated if this component is implemented directly in maas-ui. You can replicate this by maximising your browser window, and the placeholder text should seem misaligned. Opening and closing dev tools also causes misalignment, and importing this component into maas-ui also causes the For now, I'm implementing this component directly in maas-ui, but I've created a jira ticket to eventually upstream it to maas-react-components and fix these bugs. For now though, this has been blocking the reserved IPs work, so I'm putting this PR on hold |
Done
QA steps
immutableText
cannot be modified by typing in the input fieldScreenshots