Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tag management panel MAASENG-1427 #5051

Merged
merged 1 commit into from
Jul 28, 2023
Merged

feat: tag management panel MAASENG-1427 #5051

merged 1 commit into from
Jul 28, 2023

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Jul 12, 2023 •
edited
Loading

Done

  • feat: tag management panel MAASENG-1427
    • remove .l-aside visibility workaround
    • refactor AppSidePanel
    • update node action menu dropdown styles
    • remove eslint-disable-next-line cypress/no-force comments as we disable the rule globally due to vanillaframework implementation of form elements

Details on the design: https://warthogs.atlassian.net/browse/MAASENG-1422

QA

QA steps

  • Go to machine list page
  • Select a machine
  • Click categorise -> tag
  • type a name of a new tag in the search field
  • add a new tag
  • Click save
  • Ensure the machine has been updated correctly
  • go to machine details page
  • Click categorise -> tag
  • type a name of a new tag in the search field
  • add a new tag
  • Click save
  • Ensure the machine has been updated correctly
  • Go to devices page
  • Press "Add"
  • Click "Controllers" in the navigation menu
  • Verify the side panel has been closed

Fixes

Fixes: https://warthogs.atlassian.net/browse/MAASENG-1427

Screenshots

After

image
image

Node action menu - mobile

Before

After

Node action menu - desktop

Before

After

@webteam-app
Copy link

Demo starting at https://maas-ui-5051.demos.haus

@petermakowski petermakowski force-pushed the feat-tag-management-panel-MAASENG-1427 branch 4 times, most recently from 053c192 to d94a3d2 Compare July 14, 2023 14:02
@petermakowski petermakowski changed the title feat: tag management panel MAASENG-1427 WIP feat: tag management panel MAASENG-1427 Jul 14, 2023
@petermakowski petermakowski marked this pull request as ready for review July 14, 2023 14:04
@petermakowski petermakowski force-pushed the feat-tag-management-panel-MAASENG-1427 branch from d94a3d2 to 2a51552 Compare July 14, 2023 14:05
@petermakowski petermakowski changed the title feat: tag management panel MAASENG-1427 feat: tag management panel MAASENG-1427 WIP Jul 14, 2023
@petermakowski petermakowski force-pushed the feat-tag-management-panel-MAASENG-1427 branch 3 times, most recently from b88d10b to 6954b3c Compare July 21, 2023 08:56
@petermakowski petermakowski force-pushed the feat-tag-management-panel-MAASENG-1427 branch 6 times, most recently from d09dae9 to a59428c Compare July 28, 2023 12:00
@petermakowski petermakowski force-pushed the feat-tag-management-panel-MAASENG-1427 branch 2 times, most recently from 75cd678 to ae5a909 Compare July 28, 2023 12:08
@petermakowski petermakowski changed the title feat: tag management panel MAASENG-1427 WIP feat: tag management panel MAASENG-1427 Jul 28, 2023
@petermakowski petermakowski force-pushed the feat-tag-management-panel-MAASENG-1427 branch 3 times, most recently from 7ec770b to 6f5428a Compare July 28, 2023 13:04
@petermakowski
feat: tag management panel MAASENG-1427
e5bb0da 
- remove .l-aside.is-collapsed workaround
- extract ResponsiveNodeActionMenu component
@petermakowski petermakowski force-pushed the feat-tag-management-panel-MAASENG-1427 branch from 6f5428a to e5bb0da Compare July 28, 2023 13:25
ndv99
ndv99 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome man, LGTM

@petermakowski petermakowski merged commit 9074ea6 into canonical:main Jul 28, 2023
4 checks passed
@petermakowski petermakowski deleted the feat-tag-management-panel-MAASENG-1427 branch May 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

@Jay-Topher Jay-Topher Awaiting requested review from Jay-Topher

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @ndv99