Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use builder callback MAASENG-1855 #5105

Merged
merged 1 commit into from
Aug 21, 2023
Merged

refactor: use builder callback MAASENG-1855 #5105

merged 1 commit into from
Aug 21, 2023

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Aug 21, 2023 •
edited
Loading

Done

  • refactor: use builder callback MAASENG-1855

This removes redux toolkit deprecation warning for extraReducers.

https://redux-toolkit.js.org/api/createSlice#the-extrareducers-builder-callback-notation

QA

QA Steps

  1. Go to MAAS/r/account/prefs/details
  2. Open developer tools and redux devtools
  3. Edit Full name and submit
  4. Verify that auth user last_name has been updated

Fixes

Fixes: https://warthogs.atlassian.net/browse/MAASENG-1855

@webteam-app
Copy link

Demo starting at https://maas-ui-5105.demos.haus

@petermakowski petermakowski marked this pull request as ready for review August 21, 2023 09:27
@petermakowski petermakowski merged commit e35913c into canonical:main Aug 21, 2023
4 checks passed
@petermakowski petermakowski deleted the refactor-builder-callback-MAASENG-1855 branch May 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @ndv99