Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set BondFormFields initialValues #5110

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Aug 21, 2023

Done

  • test: set BondFormFields initialValues
  • test: use toHaveAccessibleErrorMessage

Fixes the following error thrown when running BondFormFields.test.tsx test:

Warning: A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components

Fixes the following error across the codebase:

Warning: toHaveErrorMessage has been deprecated and will be removed in future updates. Please use toHaveAccessibleErrorMessage.

@webteam-app
Copy link

Demo starting at https://maas-ui-5110.demos.haus

Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@petermakowski petermakowski merged commit 6c07131 into canonical:main Aug 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants