chore: Fix linting #149
Merged
chore: Fix linting #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
requested changes
Feb 6, 2025
orfeas-k
previously approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Hey @mvlassis , I documented our findings here canonical/kfp-operators#675. We 're good to proceed without any modifications but let's keep in mind when integrating the rock, that we should run the services as _daemon_ user.
mvlassis
force-pushed
the
kf-6813-metacontroller-manifests
branch
from
3aca660 to
7103969
Compare
mvlassis
changed the title
orfeas-k
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR to update the manifest files, but they haven't changed since the previous versions.
For reference, the upstream manifests are located here.
Note that the new manifests have an added
securityContextfield, which I am not including, see the track issue.