Add MetalLB in FRR mode via flags, add webhookvalidation disable option #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to enable the MetalLB plugin in FRR mode. This is required for IPv6 Peering sessions.
While writing tests for this mode, i came across an issue with the
validatingwebhookconfiguration
, which is described here:metallb/metallb#1597
As the maintainers of MetalLB say themselves, this issue is entirely unpredictable and occurs seemingly at random. This is kind of bad, especially for automated tests. Hence, I added a turn-off flag for the validation webhooks. This can be dangerous, as the manifests wont get sanity checked by metallb then, so i only added the possibility to turn this off via the flags and not via the prompt. This way, we can disable them during tests, while keeping the user from just disabling them without knowing what that actually means.
You can also take a look at this blogpost: https://blog.mowoe.com/building-a-multi-node-ipv6-enabled-bare-metal-kubernetes-cluster-with-microk8s-metallb-longhorn-and-vyos.html
to learn more about why frr-mode is handy.