Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microk8s.leave single leader guard #1462

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Conversation

ktsakalozos
Copy link
Member

@ktsakalozos ktsakalozos commented Jul 31, 2020

We should not allow a node to leave the cluster (microk8s.leave) in the case where:

  • That node is the leader
  • There are no other voters to take over leadership
  • There are non-voters that need the leader

@ktsakalozos ktsakalozos requested a review from joedborg July 31, 2020 14:13
Copy link
Contributor

@joedborg joedborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ktsakalozos ktsakalozos merged commit db9212e into feature/ha-enable Jul 31, 2020
@ktsakalozos ktsakalozos deleted the feature/leave-guard branch July 31, 2020 21:09
ktsakalozos added a commit that referenced this pull request Aug 17, 2020
ktsakalozos added a commit that referenced this pull request Aug 20, 2020
* First pass on microk8s enable

* Add pie chart to the grafana of prometheus operator

* Revert "Add pie chart to the grafana of prometheus operator"

This reverts commit 1c28dc6.

* Handle distribute an operation across nodes (#1297)

* Handle dqlite and cluster agent ports on HA cluster

* Fix distributed ops on single node cluster (#1320)

* Start dqlite and calico by default

* Do not try to distribute configuration when cluster agent is stopped

* Dqlite without REST interface

* Remove the ha-cluster subcommand from status (#1374)

* Remove the ha-cluster subcommand from status

* fix enabling of dns when running HA. (#1403)

* Fix LXC deployments, umount kubelet when removing microk8s (#1424)

* Stopping control plane on HA (#1406)

* Change ownership of files under the dqlite path (#1429)

* Change ownership of files under the dqlite path

* Address review comments

* Add message in joining (#1452)

* Handle not reachable nodes (#1450)

* Fixes #1448 (#1457)

* microk8s.leave single leader guard (#1462)

* Fix cilium in an ha cluster (#1453)

* dbctl for dqlite backup and restore (#1435)

Co-authored-by: balchua <balchua@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants