Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't re-send wl_output.geometry if unchanged #3414

Closed
Saviq opened this issue Jun 5, 2024 · 1 comment · Fixed by #3430
Closed

Don't re-send wl_output.geometry if unchanged #3414

Saviq opened this issue Jun 5, 2024 · 1 comment · Fixed by #3430
Labels
enhancement triaged Triage into JIRA to plan it in

Comments

@Saviq
Copy link
Collaborator

Saviq commented Jun 5, 2024

Correction: we would be correct to resend geometry if any of the properties changed:

The event is sent when binding to the output object and whenever any of the properties change.

Originally posted by @AlanGriffiths in #3393 (comment)
@Saviq
Copy link
Collaborator Author

Saviq commented Jun 5, 2024 •
edited
Loading

These got introduced here:

@Saviq Saviq added the triaged Triage into JIRA to plan it in label Jun 17, 2024
hbatagelo added a commit that referenced this issue Jun 18, 2024
@hbatagelo
(#3414) Don't re-send wl_output.geometry if unchanged
68eb5cc
@hbatagelo hbatagelo mentioned this issue Jun 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 18, 2024
@AlanGriffiths
(#3414) Don't re-send wl_output.geometry if unchanged (#3430)
601aa2b 
Fixes #3414

Removes a duplicate call to
`OutputConfigListener::output_config_changed` during the binding of the
output object.
Saviq pushed a commit that referenced this issue Aug 21, 2024
@AlanGriffiths @Saviq
(#3414) Don't re-send wl_output.geometry if unchanged (#3430)
38c9b0a 
Fixes #3414

Removes a duplicate call to
`OutputConfigListener::output_config_changed` during the binding of the
output object.
@hbatagelo hbatagelo mentioned this issue Sep 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 6, 2024
@AlanGriffiths
Fix missing wl_surface.enter events for outputs enabled at runtime. (…
99e8ffa 
…#3585)

In my [previous fix](#3430) for
#3414, I accidentally disabled sending `wl_surface.enter` events for
surfaces on outputs enabled at runtime. This PR resolves that issue
while still addressing #3414.
AlanGriffiths added a commit that referenced this issue Sep 9, 2024
@AlanGriffiths
Fix missing wl_surface.enter events for outputs enabled at runtime. (…
910d3b8 
…#3585)

In my [previous fix](#3430) for
#3414, I accidentally disabled sending `wl_surface.enter` events for
surfaces on outputs enabled at runtime. This PR resolves that issue
while still addressing #3414.
@AlanGriffiths AlanGriffiths mentioned this issue Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement triaged Triage into JIRA to plan it in
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#3414) Don't re-send wl_output.geometry if unchanged canonical/mir
1 participant
@Saviq