Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-1106-more #1110

Merged
merged 2 commits into from
Nov 30, 2019
Merged

fix-1106-more #1110

merged 2 commits into from
Nov 30, 2019

Conversation

AlanGriffiths
Copy link
Contributor

We should stop accepting "commit" and disconnect if a surface has gone.

wmww
wmww approved these changes Nov 30, 2019
View reviewed changes
Copy link
Contributor

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
bors r+

bors bot added a commit that referenced this pull request Nov 30, 2019
@bors @AlanGriffiths
Merge #1110
69783c5 
1110: fix-1106-more r=wmww a=AlanGriffiths

We should stop accepting "commit" and disconnect if a surface has gone.

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
@bors
Copy link
Contributor

bors bot commented Nov 30, 2019

Build succeeded

@bors bors bot merged commit bf0b7b7 into master Nov 30, 2019
@bors bors bot deleted the fix-1106-more branch November 30, 2019 03:34
AlanGriffiths added a commit that referenced this pull request Dec 3, 2019
@bors @AlanGriffiths
Merge #1110
fa4cfaf 
1110: fix-1106-more r=wmww a=AlanGriffiths

We should stop accepting "commit" and disconnect if a surface has gone.

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
@AlanGriffiths AlanGriffiths mentioned this pull request Feb 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmww wmww wmww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanGriffiths @wmww