Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert rules to mlflow-server based on the KF093 spec #262

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Aug 15, 2024

These alert rules provide an overview of all service states.

Using the KubeflowServiceDown or KubeflowServiceIsNotStable filter, the user
can easily see the status of all Kubeflow services.

These changes can be tested by running the following commands:

tox -e integration -- --keep-models
juju -m <model-name> show-unit grafana-agent-k8s/0 --endpoint metrics-endpoint | yq '.[]."relation-info".[]."application-data".alert_rules | fromjson'
# if you have cos deployed
juju consume <controller>:cos.remote-write
juju integrate remote-write grafana-agent-k8s
# open Grafana UI and check if KubeflowServiceDown and KubeflowServiceIsNotStable are there
# you can even stop pebble service to see alert rules firing
kubectl exec -it -n <model-name> pod/<pod-name> -c <workload-container> -- /charm/bin/pebble start <service-name>

part-of: #1026

@rgildein rgildein requested a review from a team as a code owner August 15, 2024 10:25
@rgildein rgildein force-pushed the chore/KF-6125/add-rules-mlflow-server branch from 2d43f43 to aec9e55 Compare August 15, 2024 14:54
@rgildein rgildein requested a review from misohu August 21, 2024 07:54
@rgildein rgildein merged commit 9f32fb6 into main Aug 21, 2024
8 checks passed
@rgildein rgildein deleted the chore/KF-6125/add-rules-mlflow-server branch August 21, 2024 08:00
misohu pushed a commit that referenced this pull request Oct 8, 2024
* Add alert rules to mlflow-server based on the KF093 spec

* Delete src/prometheus_alert_rules/unit_unavailable.rule

* Use chisme to test cos integration
misohu added a commit that referenced this pull request Oct 11, 2024
* Add alert rules to mlflow-server based on the KF093 spec

* Delete src/prometheus_alert_rules/unit_unavailable.rule

* Use chisme to test cos integration

Co-authored-by: Robert Gildein <gildeinrobert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants