Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-4906] - Make libs k8s friendly #438

Merged
merged 12 commits into from
Jul 26, 2024
Merged

[DPE-4906] - Make libs k8s friendly #438

merged 12 commits into from
Jul 26, 2024

Conversation

MiaAltieri
Copy link
Contributor

@MiaAltieri MiaAltieri commented Jul 24, 2024 •
edited
Loading

Issue

  1. MongoDB K8s charm cannot use some of the shared code in the lib
  2. MongoDB K8s charm is copying over an excessive amount of the status code

Solution

  1. use a universal name to retrieve hosts across charms
  2. move shared status code to set_status lib

Lib versions

currently many of the library API + Patch are out of date, so we do not bump the versions here this PR when it lands will resolve them

@MiaAltieri MiaAltieri changed the title Make libs k8s friendly [DPE-4906] - Make libs k8s friendly Jul 24, 2024
Gu1nness
Gu1nness reviewed Jul 24, 2024
View reviewed changes
lib/charms/mongodb/v0/set_status.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
MiaAltieri and others added 3 commits July 24, 2024 14:04
@MiaAltieri @Gu1nness
Apply case usage for status message
184d9c9 
Co-authored-by: Nehalenniæ Oudin <17551419+Gu1nness@users.noreply.github.com>
@MiaAltieri
pr feedback
9cb62a3
@MiaAltieri
update linter to handle match
e7dfeea
Gu1nness
Gu1nness previously approved these changes Jul 24, 2024
View reviewed changes
@MiaAltieri @Gu1nness
add another match case ⭐
28b3b8f 
Co-authored-by: Nehalenniæ Oudin <17551419+Gu1nness@users.noreply.github.com>
Gu1nness
Gu1nness previously approved these changes Jul 24, 2024
View reviewed changes
@MiaAltieri MiaAltieri requested a review from Gu1nness July 25, 2024 15:36
Gu1nness
Gu1nness previously approved these changes Jul 25, 2024
View reviewed changes
@MiaAltieri MiaAltieri requested a review from Gu1nness July 26, 2024 05:54
@MiaAltieri MiaAltieri merged commit 437b04a into 6/edge Jul 26, 2024
39 checks passed
@MiaAltieri MiaAltieri deleted the make-libs-k8s-friendly branch July 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

@Gu1nness Gu1nness Gu1nness approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiaAltieri @Gu1nness @Mehdi-Bendriss