-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple tray icons on Kubuntu 20.04 #1770
Comments
Hi @Forinil, Did you add Multipass to your auto-started apps manually? Snapd handles it through its own |
No I did not. I installed it with snap and left all the settings default. |
Something KDE is doing must be triggering the one with the |
In general yes, though one time it crashed - there was no text in the menu and no way to get rid of it, other than killing the process. But that time the CLI did not work either and after a restart everything went back to normal - that is I still had two icons, but the |
So yesterday I had the same issue with no text in the menu and multipass not working at all and today there's only one icon and everything works fine. There seems to be no rhyme or reason to this. |
Hi My KDE Neon 20.04 has this issue as well.. except it has 3 icons. Haven't done anything apart from the bog-standard install and there is nothing I can see in KDE's autostart/startup. 2 icons show "Failure retrieving instances" on right click and the other shows the machine name. All 3 do nothing on left click.
I can see this line in .xsession-errors:
Happy to poke around relevant system locations that could hold clues, if someone could out where they are. |
Hi @Forinil, @MrJamesEllis, that Also, what does the following say?
|
>for pid in `pgrep multipass.gui` ; do echo --- $pid:; pstree -alsp $pid ; done
--- 2432:
systemd,1 splash
└─kdeinit5,2266
└─multipass.gui,2432 -session 101a01b610614a000160198426900000022540012_1601994595_462904
├─{multipass.gui},2440
├─{multipass.gui},2442
├─{multipass.gui},2444
├─{multipass.gui},2445
├─{multipass.gui},2448
├─{multipass.gui},2534
├─{multipass.gui},2535
└─{multipass.gui},2556
--- 2489:
systemd,1 splash
└─multipass.gui,2489 --autostarting
├─{multipass.gui},2526
├─{multipass.gui},2537
├─{multipass.gui},2538
├─{multipass.gui},2539
├─{multipass.gui},2540
├─{multipass.gui},2544
├─{multipass.gui},2545
└─{multipass.gui},2551 @MrJamesEllis I titled this issue |
Thank you @Forinil. And another piece of info if you may, to help us figure out how best to approach this: can you confirm that, if you kill the multipass.gui process(es) that have |
@ricab I was already asked this question. My answers were
By the way - today two icons again, one working and one not. |
Ah ok, I missed that. It would still be useful to make sure it is always that one that works (and not just the one that starts first, for instance). But it should be, if we got it right. |
Hi all, @ricab implemented a workaround in #1791, which will prevent the icon from starting if it's invoked with the -session argument. In a few minutes you should be able to test with Multipass from the As far we can tell, it is KDE trying to restore the icon on session startup, which it shouldn't do, and certainly not the way it does it (outside of the snap environment). |
I did a test and started manuallu quitting I switched the snap to channel |
Correct, this functionality is in progress in snapd, see: https://forum.snapcraft.io/t/wip-refresh-app-awareness/10736 |
1791: [gui] Refuse session restoring r=Saviq a=ricab Hopefully fixes #1770. Qt consumes `-session <id>` from the command line before we have a chance to parse it. When we parse the `QApplication::arguments()`, it's no longer there, so we continued happily. But then we were not running with a proper environment, so no luck reaching the daemon. Since we don't implement session restoring, we need to explicitly refuse the attempt. This is only applicable to `QGuiApplication`s, so it does not affect our other binaries. References: - https://doc.qt.io/qt-5/qguiapplication.html#supported-command-line-options - https://code.woboq.org/qt5/qtbase/src/gui/kernel/qguiapplication.cpp.html#1547 - https://code.woboq.org/qt5/qtbase/src/gui/kernel/qguiapplication.cpp.html#1573 - https://doc.qt.io/qt-5/session.html Co-authored-by: Ricardo Abreu <ricab@ricabhome.org>
I know this is closed and all, I've been away and have only just been able to test this. Using the edge/pr1791 refresh, signing out and signing in again there is only one multipass.gui icon and it was able to start the instance. Interestingly, right clicking on the icon after closing the instance shows a context menu with not text, I don't think it's related to this issue, tho: FTR, here are the results of that command prior to refreshing from edge/pr1791 $ for pid in `pgrep multipass.gui` ; do echo --- $pid:; pstree -alsp $pid ; done
--- 70779:
systemd,1 splash
└─ksmserver,70672
└─multipass.gui,70779 -session 10e4c66b61000160075649100000068730009_1602751923_312964
├─{multipass.gui},70784
├─{multipass.gui},70787
├─{multipass.gui},70788
├─{multipass.gui},70789
├─{multipass.gui},70790
├─{multipass.gui},70852
├─{multipass.gui},70853
├─{multipass.gui},70854
├─{multipass.gui},70855
├─{multipass.gui},70856
├─{multipass.gui},70864
└─{multipass.gui},70883
--- 70786:
systemd,1 splash
└─ksmserver,70672
└─multipass.gui,70786 -session 10e4c66b61000160090008900000025110009_1602751923_312967
├─{multipass.gui},70791
├─{multipass.gui},70797
├─{multipass.gui},70798
├─{multipass.gui},70799
├─{multipass.gui},70800
├─{multipass.gui},70847
├─{multipass.gui},70848
├─{multipass.gui},70849
├─{multipass.gui},70850
├─{multipass.gui},70851
├─{multipass.gui},70862
├─{multipass.gui},70863
└─{multipass.gui},70882
--- 70796:
systemd,1 splash
└─ksmserver,70672
└─multipass.gui,70796 -session 10e4c66b61000160264215800000021290008_1602751923_313036
├─{multipass.gui},70802
├─{multipass.gui},70811
├─{multipass.gui},70812
├─{multipass.gui},70813
├─{multipass.gui},70814
├─{multipass.gui},70857
├─{multipass.gui},70858
├─{multipass.gui},70859
├─{multipass.gui},70860
├─{multipass.gui},70861
└─{multipass.gui},70884
--- 70885:
systemd,1 splash
└─ksmserver,70672
└─multipass.gui,70885 -session 10e4c66b61000160264302600000665630010_1602751923_313184
├─{multipass.gui},70886
├─{multipass.gui},70887
├─{multipass.gui},70888
├─{multipass.gui},70889
├─{multipass.gui},70890
├─{multipass.gui},70914
├─{multipass.gui},70915
├─{multipass.gui},70916
├─{multipass.gui},70917
├─{multipass.gui},70918
└─{multipass.gui},71006
--- 70919:
systemd,1 splash
└─multipass.gui,70919 --autostarting
├─{multipass.gui},70975
├─{multipass.gui},70976
├─{multipass.gui},70977
├─{multipass.gui},70978
├─{multipass.gui},70979
├─{multipass.gui},71002
├─{multipass.gui},71003
└─{multipass.gui},71005 |
Hi @MrJamesEllis, thanks getting back to us. So everything is as anticipated regarding this issue and I am glad it's working for you now. On the menu with no text, yeah that would be a separate problem. Do you observe that consistently, or was it a one-off thing? Did you perhaps get that after the snap refresh, for a previously running GUI? Feel free to open a new bug report. |
1791: [gui] Refuse session restoring r=Saviq a=ricab Hopefully fixes #1770. Qt consumes `-session <id>` from the command line before we have a chance to parse it. When we parse the `QApplication::arguments()`, it's no longer there, so we continued happily. But then we were not running with a proper environment, so no luck reaching the daemon. Since we don't implement session restoring, we need to explicitly refuse the attempt. This is only applicable to `QGuiApplication`s, so it does not affect our other binaries. References: - https://doc.qt.io/qt-5/qguiapplication.html#supported-command-line-options - https://code.woboq.org/qt5/qtbase/src/gui/kernel/qguiapplication.cpp.html#1547 - https://code.woboq.org/qt5/qtbase/src/gui/kernel/qguiapplication.cpp.html#1573 - https://doc.qt.io/qt-5/session.html Co-authored-by: Ricardo Abreu <ricab@ricabhome.org>
Describe the bug
Multipass started showing multiple icons in system tray. Only one of them works correctly, the rest shows
Failure retrieving instances
To Reproduce
Unfortunately, I do not know how to reproduce this. I installed Kubuntu 20.04 and mutlipass shortly after the former came out. I did not experience any problems initially. I only noticed the additional icons a couple weeks ago. I update my system regularly using apt.
Expected behavior
A single, working multipass icon in the system tray.
Additional info
multipass version
multipass info --all
ps -ef | grep multipass
(while two tray icons are shown)Additional info
After I right-clik the tray icon reporting failure retrieving instances and select quit,
ps -ef
no longer shows line withmultipass.gui -session
:The text was updated successfully, but these errors were encountered: