Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lxd] Some LXD reply data is cut off #1938

Closed
townsend2010 opened this issue Jan 25, 2021 · 0 comments · Fixed by #1940
Closed

[lxd] Some LXD reply data is cut off #1938

townsend2010 opened this issue Jan 25, 2021 · 0 comments · Fixed by #1940
Assignees
@townsend2010
Labels
bug
Milestone
v1.7.0

Comments

@townsend2010
Copy link
Contributor

As seen in #1927, the reply data from LXD is not being fully read, leading to "illegal" JSON. We need to see if there is more data to be read in the reply before moving on.
@townsend2010 townsend2010 self-assigned this Jan 25, 2021
townsend2010 pushed a commit that referenced this issue Jan 26, 2021
[local_socket_reply] Fix reading actual chunked transfer types
73ffe73 
Fixes #1938
@townsend2010 townsend2010 mentioned this issue Jan 26, 2021
Merged
townsend2010 pushed a commit that referenced this issue Jan 28, 2021
[local_socket_reply] Fix reading actual chunked transfer types
5971c74 
Fixes #1938
townsend2010 pushed a commit that referenced this issue Jan 29, 2021
[local_socket_reply] Fix reading actual chunked transfer types
5edf513 
Fixes #1938
townsend2010 pushed a commit that referenced this issue Feb 19, 2021
[local_socket_reply] Fix reading actual chunked transfer types
da63b20 
Fixes #1938
bors bot added a commit that referenced this issue Mar 17, 2021
@bors
Merge #1931 #1940
615603a 
1931: [LXD] Support HTTP & file based launches r=Saviq a=townsend2010



1940: [local_socket_reply] Handle multiple chunked transfers r=Saviq a=townsend2010

Fixes #1938 

Co-authored-by: Chris Townsend <christopher.townsend@canonical.com>
@bors bors bot closed this as completed in ff38f08 Mar 17, 2021
@Saviq Saviq added this to the v1.7.0 milestone Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@townsend2010 townsend2010

Labels
bug
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging a pull request may close this issue.

[local_socket_reply] Handle multiple chunked transfers canonical/multipass
2 participants
@Saviq @townsend2010