[lxd] increase first boot timeout to 20s #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This impacts only the "Instance shutdown during start" situation on LXD. I verified 5s is not enough on a Pi4, and the worst case is that this will delay `launch` failing when someone did indeed stop the instance being started.
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 229 229
Lines 8512 8512
=======================================
Hits 6550 6550
Misses 1962 1962
Continue to review full report at Codecov.
|
townsend2010
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impacts only the "Instance shutdown during start" situation on LXD. I verified 5s is not enough on a Pi4, and the worst case is that this will delay
launchfailing when someone did indeed stop the instance being started.