Fix compilation with Clang 12 on Linux. #2191
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2191 +/- ##
=======================================
Coverage 82.98% 82.98%
=======================================
Files 186 186
Lines 9730 9730
=======================================
Hits 8074 8074
Misses 1656 1656 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Yeah, it's a pain that we can't capture structured bindings (until C++20 I think). FWIW, you can still use regular vars, to conserve the names and avoid repeating get<> if you need them more than once:
const auto& param = GetParam();
const auto& expected_firewall = std::get<0>(param);
...It's perhaps not too relevant here though, so accepting.
bors r+
|
Build failed: |
|
bors retry |
|
Build failed: |
|
bors merge |
2190: [firewall] Fix detection of nftables support in kernel r=Saviq a=townsend2010 Fixes #2183 2191: Fix compilation with Clang 12 on Linux. r=Saviq a=luis4a0 Clang is picky with lambda captures. Co-authored-by: Chris Townsend <christopher.townsend@canonical.com> Co-authored-by: Luis Peñaranda <luis.penaranda@canonical.com>
|
Build failed (retrying...): |
|
Build failed: |
|
bors r=ricab |
|
Build failed: |
|
Oh dear. bors r+ |
|
Build failed: |
|
Let's retry... there is a couple of combinations backend/platform which still didn't fail. Come on CI, go for it! 😂 |
|
Sure, here goes bors r+ |
|
Build failed: |
Clang is picky with lambda captures.